[prev in list] [next in list] [prev in thread] [next in thread] 

List:       cairo
Subject:    [cairo] Fix a thinko in color glyph support
From:       Matthias Clasen <matthias.clasen () gmail ! com>
Date:       2019-05-31 13:59:34
Message-ID: CAFwd_vCVLLXxz4s3Jrk+4k_D+fnV13mip-wC0Nxgbo1rSefgFg () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


I've spent some time tracking down a GTK+ / Pango crash (
https://gitlab.gnome.org/GNOME/pango/issues/346 ).

Turns out that there was a thinko in our original color glyph patch. We
can't modify the passed-in text.

Here is a quick fix:

https://github.com/matthiasclasen/cairo/commit/79ad01724161502e8d9d2bd384ff1f0174e5df6e

This probably needs to go into a stable cairo branch too.

[Attachment #5 (text/html)]

<div dir="ltr"><div>I&#39;ve spent some time tracking down a GTK+ / Pango crash ( <a \
href="https://gitlab.gnome.org/GNOME/pango/issues/346">https://gitlab.gnome.org/GNOME/pango/issues/346</a> \
).</div><div><br></div><div>Turns out that there was a thinko in our original color \
glyph patch. We</div><div>can&#39;t modify the passed-in \
text.</div><div><br></div><div>Here is a quick fix:<br></div><div><br></div><div><a \
href="https://github.com/matthiasclasen/cairo/commit/79ad01724161502e8d9d2bd384ff1f017 \
4e5df6e">https://github.com/matthiasclasen/cairo/commit/79ad01724161502e8d9d2bd384ff1f0174e5df6e</a></div><div><br></div><div>This \
probably needs to go into a stable cairo branch too.<br></div></div>


[Attachment #6 (text/plain)]

-- 
cairo mailing list
cairo@cairographics.org
https://lists.cairographics.org/mailman/listinfo/cairo

[prev in list] [next in list] [prev in thread] [next in thread]