[prev in list] [next in list] [prev in thread] [next in thread]
List: cairo
Subject: Re: [cairo] OpenType font variations and cairo
From: Behdad Esfahbod <behdad.esfahbod () gmail ! com>
Date: 2017-09-28 23:03:37
Message-ID: CAF63+7Wd5s1SiM4iiQUwyVW-QLqrT5MYxMJ6HipDM+BD3d78bA () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
+Khaled,Werner
Two things:
* Werner, please please please remove code that change face->face_index.
It's bad bad bad.
* With Matthias's branch, we break Khaled's code, ie. if user creates
FT_Face, sets variations on it, and creates cairo_face_t from, we reset /
ignore those variations. The fix would require savings the variations that
were on the face when face was created, and use those instead of
instance-defaults in apply_variations(). Matthias, any chance you can do
this?
b
On Thu, Sep 28, 2017 at 7:01 PM, Behdad Esfahbod <behdad.esfahbod@gmail.com>
wrote:
> On Thu, Sep 28, 2017 at 6:09 PM, Adrian Johnson <ajohnson@redneon.com>
> wrote:
>
>> On 29/09/17 06:06, Matthias Clasen wrote:
>> I pulled your latest changes and tested with various combinations of
>> freetype and fontconfig - see below. All good on the cairo side, except
>> for the build fail with FT 2.6.3 but I mentioned that needs fixing in my
>> review comments.
>>
>> There appears to be a bug in fontconfig master when using freetype 2.8.
>>
>> If you cleanup and rebase your commits to master with all review
>> comments addressed, I'll do a final check and then it should be good to
>> commit.
>>
>
> Thanks Adrian for all the help.
>
> freetype 2.6.3: build failed - FT_Get_Var_Design_Coordinates not found
>>
>> freetype 2.8, fontconfig 2.11.0 : pass
>>
>> freetype 2.8, fontconfig 2.12.5 : pass
>>
>> freetype 2.8, fontconfig master :
>>
>> When running the fc-cache built from master I get:
>> fc-cache: fcfreetype.c:2143: IA__FcFreeTypeQueryAll: Assertion
>> `mm_var' failed.
>>
>> fc-cache succeeds after removing AdobeVFPrototype.ttf from ~/.fonts
>>
>> I tried again with AdobeVFPrototype.otf. fc-cache ran successfully and
>> the cairo test passed.
>>
>
> Humm. This sounds very much like what might happen with old FreeType . If
> not, can you elaborate what happens again? Can you reproduce? What
> FreeType exactly? Does `fc-query AdobeVFPrototype.ttf` work?
>
> I can probably replace assert with a less harsh mode of failure.
>
>
>
>> freetype 2.8.1, fontconfig 2.11.0 : pass
>>
>> freetype 2.8.1, fontconfig 2.12.5 : pass
>>
>> freetype 2.8.1, fontconfig master : pass
>>
>> freetype master, fontconfig master : pass
>>
>>
>>
>>
>>
>>
>
>
> --
> behdad
> http://behdad.org/
>
--
behdad
http://behdad.org/
[Attachment #5 (text/html)]
<div dir="ltr"><div><div><div><div>+Khaled,Werner<br><br></div>Two \
things:<br><br></div> * Werner, please please please remove code that change \
face->face_index. It's bad bad bad.<br><br></div> * With Matthias's \
branch, we break Khaled's code, ie. if user creates FT_Face, sets variations on \
it, and creates cairo_face_t from, we reset / ignore those variations. The fix \
would require savings the variations that were on the face when face was created, and \
use those instead of instance-defaults in apply_variations(). Matthias, any chance \
you can do this?<br><br></div>b<br></div><div class="gmail_extra"><br><div \
class="gmail_quote">On Thu, Sep 28, 2017 at 7:01 PM, Behdad Esfahbod <span \
dir="ltr"><<a href="mailto:behdad.esfahbod@gmail.com" \
target="_blank">behdad.esfahbod@gmail.com</a>></span> wrote:<br><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div \
class="gmail_quote"><span class="">On Thu, Sep 28, 2017 at 6:09 PM, Adrian Johnson \
<span dir="ltr"><<a href="mailto:ajohnson@redneon.com" \
target="_blank">ajohnson@redneon.com</a>></span> wrote:<br></span><blockquote \
class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid \
rgb(204,204,204);padding-left:1ex"><span class=""><span \
class="m_-4985086479486413769gmail-">On 29/09/17 06:06, Matthias Clasen \
wrote:<br></span></span><span class="">I pulled your latest changes and tested with \
various combinations of<br> freetype and fontconfig - see below. All good on the \
cairo side, except<br> for the build fail with FT 2.6.3 but I mentioned that needs \
fixing in my<br> review comments.<br>
<br>
There appears to be a bug in fontconfig master when using freetype 2.8.<br>
<br>
If you cleanup and rebase your commits to master with all review<br>
comments addressed, I'll do a final check and then it should be good to<br>
commit.<br></span></blockquote><div><br>Thanks Adrian for all the help.<br><br> \
</div><span class=""><blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> freetype 2.6.3: build \
failed - FT_Get_Var_Design_Coordinates not found<br> <br>
freetype 2.8, fontconfig 2.11.0 : pass<br>
<br>
freetype 2.8, fontconfig 2.12.5 : pass<br>
<br>
freetype 2.8, fontconfig master :<br>
<br>
When running the fc-cache built from master I get:<br>
fc-cache: fcfreetype.c:2143: IA__FcFreeTypeQueryAll: Assertion<br>
`mm_var' failed.<br>
<br>
fc-cache succeeds after removing AdobeVFPrototype.ttf from ~/.fonts<br>
<br>
I tried again with AdobeVFPrototype.otf. fc-cache ran successfully and<br>
the cairo test passed.<br></blockquote><div><br></div></span><div>Humm. This sounds \
very much like what might happen with old FreeType . If not, can you elaborate what \
happens again? Can you reproduce? What FreeType exactly? Does `fc-query \
AdobeVFPrototype.ttf` work?<br><br></div><div>I can probably replace assert with a \
less harsh mode of failure.<br><br></div><span class=""><div> </div><blockquote \
class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid \
rgb(204,204,204);padding-left:1ex"> freetype 2.8.1, fontconfig 2.11.0 : pass<br>
<br>
freetype 2.8.1, fontconfig 2.12.5 : pass<br>
<br>
freetype 2.8.1, fontconfig master : pass<br>
<br>
freetype master, fontconfig master : pass<br>
<br>
<br>
<br>
<br>
<br>
</blockquote></span></div><span class="HOEnZb"><font color="#888888"><br><br \
clear="all"><br>-- <br><div \
class="m_-4985086479486413769gmail_signature">behdad<br><a href="http://behdad.org/" \
target="_blank">http://behdad.org/</a></div> </font></span></div></div>
</blockquote></div><br><br clear="all"><br>-- <br><div class="gmail_signature" \
data-smartmail="gmail_signature">behdad<br><a href="http://behdad.org/" \
target="_blank">http://behdad.org/</a></div> </div>
[Attachment #6 (text/plain)]
--
cairo mailing list
cairo@cairographics.org
https://lists.cairographics.org/mailman/listinfo/cairo
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic