[prev in list] [next in list] [prev in thread] [next in thread] 

List:       cairo
Subject:    Re: [cairo] OpenType font variations and cairo
From:       Behdad Esfahbod <behdad.esfahbod () gmail ! com>
Date:       2017-09-21 18:47:46
Message-ID: CAF63+7W0sy_D5sCY+F82Q3HRB0yhVYYS=CVz4M_=USBDJd=1sQ () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


I'll try to take a look today as well.  Looping in Werner.

Let's aim to have this sorted out this week and commit.  I'll be travelling
again for multiple weeks and don't want to see what happened to color-fonts
patchset to happen here.

On Thu, Sep 21, 2017 at 4:22 AM, Matthias Clasen <matthias.clasen@gmail.com>
wrote:

>
>
> On Thu, Sep 21, 2017 at 5:42 AM, Adrian Johnson <ajohnson@redneon.com>
> wrote:
>
>> On 21/09/17 12:03, Matthias Clasen wrote:
>> > On Wed, Sep 20, 2017 at 6:15 PM, Behdad Esfahbod
>> > <behdad.esfahbod@gmail.com <mailto:behdad.esfahbod@gmail.com>> wrote:
>> >
>> >     The test was really broken...
>> >
>> >     Ok, I've pushed some things there that should help Matthias move
>> foward:
>> >
>> >       https://github.com/behdad/cairo/commits/font-variations
>> >     <https://github.com/behdad/cairo/commits/font-variations>
>> >
>> >
>> > Thanks for those fixes, Behdad. Taking another look at the test, I'm not
>> > sure what I was thinking - it was checking the width axis, but the font
>> > we use only has weight and contrast as axes.
>> > i've pushed all the fixes to
>> >
>> > https://github.com/matthiasclasen/cairo/tree/wip/matthiasc/
>> font-variations
>> >
>> > Does this work for you now, Adrian ?
>>
>> It works with freetype 2.8.0, but not 2.8.1. Here are the results of
>> testing with different combinations of freetype and fontconfig.
>>
>> freetype 2.8.0, fontconfig 2.11.0 : pass
>>
>> freetype 2.8.0, fontconfig 2.12.5 : pass
>>
>> freetype 2.8.0, Behdad's fontconfig (2d0063948a44) : pass
>>
>> freetype 2.8.1, fontconfig 2.11.0 : fail
>>
>>   axis Weight, value 300
>>   axis CNTR, value 0
>>   axis Weight, value 0
>>   axis CNTR, value 0
>>   Axis Weight: not expected value (0 != 300.5)
>>
>> freetype 2.8.1, fontconfig 2.12.5 : fail
>>
>>   axis Weight, value 300
>>   axis CNTR, value 0
>>   axis Weight, value 0
>>   axis CNTR, value 0
>>   Axis Weight: not expected value (0 != 300.5)
>>
>> freetype 2.8.1, Behdad's fontconfig (2d0063948a44) : fail
>>
>>   axis Weight, value 300
>>   axis CNTR, value 0
>>   axis Weight, value 0
>>   axis CNTR, value 0
>>   Axis Weight: not expected value (0 != 300.5)
>>
>>
>
> I'm seeing those failures with freetype 2.8.1 too. They are somewhat
> mysterious - if I reorder the tests different ones fail. The fact that they
> sometimes report values that are nowhere to be found in the input, and
> sometime reports 0, which is not in the allowed range for the axis
> makes me think that something goes wrong in freetype.
>



-- 
behdad
http://behdad.org/

[Attachment #5 (text/html)]

<div dir="ltr"><div>I&#39;ll try to take a look today as well.   Looping in \
Werner.<br><br></div>Let&#39;s aim to have this sorted out this week and commit.   \
I&#39;ll be travelling again for multiple weeks and don&#39;t want to see what \
happened to color-fonts patchset to happen here.<br></div><div \
class="gmail_extra"><br><div class="gmail_quote">On Thu, Sep 21, 2017 at 4:22 AM, \
Matthias Clasen <span dir="ltr">&lt;<a href="mailto:matthias.clasen@gmail.com" \
target="_blank">matthias.clasen@gmail.com</a>&gt;</span> wrote:<br><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"><div dir="ltr"><div><div class="h5"><br><div \
class="gmail_extra"><br><div class="gmail_quote">On Thu, Sep 21, 2017 at 5:42 AM, \
Adrian Johnson <span dir="ltr">&lt;<a href="mailto:ajohnson@redneon.com" \
target="_blank">ajohnson@redneon.com</a>&gt;</span> wrote:<br><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"><span>On 21/09/17 12:03, Matthias Clasen wrote:<br> &gt; On \
Wed, Sep 20, 2017 at 6:15 PM, Behdad Esfahbod<br> </span><span>&gt; &lt;<a \
href="mailto:behdad.esfahbod@gmail.com" target="_blank">behdad.esfahbod@gmail.com</a> \
&lt;mailto:<a href="mailto:behdad.esfahbod@gmail.com" \
target="_blank">behdad.esfahbod@gmail.<wbr>com</a>&gt;&gt; wrote:<br> &gt;<br>
&gt;        The test was really broken...<br>
&gt;<br>
&gt;        Ok, I&#39;ve pushed some things there that should help Matthias move \
foward:<br> &gt;<br>
&gt;           <a href="https://github.com/behdad/cairo/commits/font-variations" \
rel="noreferrer" target="_blank">https://github.com/behdad/cair<wbr>o/commits/font-variations</a><br>
 &gt;        &lt;<a href="https://github.com/behdad/cairo/commits/font-variations" \
rel="noreferrer" target="_blank">https://github.com/behdad/ca<wbr>iro/commits/font-variations</a>&gt;<br>
 &gt;<br>
&gt;<br>
&gt; Thanks for those fixes, Behdad. Taking another look at the test, I&#39;m not<br>
&gt; sure what I was thinking - it was checking the width axis, but the font<br>
&gt; we use only has weight and contrast as axes.<br>
&gt; i&#39;ve pushed all the fixes to<br>
&gt;<br>
&gt; <a href="https://github.com/matthiasclasen/cairo/tree/wip/matthiasc/font-variations" \
rel="noreferrer" target="_blank">https://github.com/matthiascla<wbr>sen/cairo/tree/wip/matthiasc/<wbr>font-variations</a><br>
 &gt;<br>
&gt; Does this work for you now, Adrian ?<br>
<br>
</span>It works with freetype 2.8.0, but not 2.8.1. Here are the results of<br>
testing with different combinations of freetype and fontconfig.<br>
<br>
freetype 2.8.0, fontconfig 2.11.0 : pass<br>
<br>
freetype 2.8.0, fontconfig 2.12.5 : pass<br>
<br>
freetype 2.8.0, Behdad&#39;s fontconfig (2d0063948a44) : pass<br>
<br>
freetype 2.8.1, fontconfig 2.11.0 : fail<br>
<br>
   axis Weight, value 300<br>
   axis CNTR, value 0<br>
   axis Weight, value 0<br>
   axis CNTR, value 0<br>
   Axis Weight: not expected value (0 != 300.5)<br>
<br>
freetype 2.8.1, fontconfig 2.12.5 : fail<br>
<br>
   axis Weight, value 300<br>
   axis CNTR, value 0<br>
   axis Weight, value 0<br>
   axis CNTR, value 0<br>
   Axis Weight: not expected value (0 != 300.5)<br>
<br>
freetype 2.8.1, Behdad&#39;s fontconfig (2d0063948a44) : fail<br>
<br>
   axis Weight, value 300<br>
   axis CNTR, value 0<br>
   axis Weight, value 0<br>
   axis CNTR, value 0<br>
   Axis Weight: not expected value (0 != 300.5)<br>
<br>
</blockquote></div></div><div class="gmail_extra"><br></div><div \
class="gmail_extra"><br></div></div></div><div class="gmail_extra">I&#39;m seeing \
those failures with freetype 2.8.1 too. They are somewhat mysterious - if I reorder \
the tests different ones fail. The fact that they</div><div \
class="gmail_extra">sometimes report values that are nowhere to be found in the \
input, and sometime reports 0, which is not in the allowed range for the \
axis</div><div class="gmail_extra">makes me think that something goes wrong in \
freetype.<br></div></div> </blockquote></div><br><br clear="all"><br>-- <br><div \
class="gmail_signature" data-smartmail="gmail_signature">behdad<br><a \
href="http://behdad.org/" target="_blank">http://behdad.org/</a></div> </div>


[Attachment #6 (text/plain)]

-- 
cairo mailing list
cairo@cairographics.org
https://lists.cairographics.org/mailman/listinfo/cairo

[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic