[prev in list] [next in list] [prev in thread] [next in thread]
List: cairo
Subject: Re: [cairo] OpenType font variations and cairo
From: Matthias Clasen <matthias.clasen () gmail ! com>
Date: 2017-09-19 11:32:40
Message-ID: CAFwd_vCmWkCaKmH1p_tuKeWw+4FXXkV--CjPfDxP93_uVrj4fA () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
On Tue, Sep 19, 2017 at 7:04 AM, Adrian Johnson <ajohnson@redneon.com>
wrote:
>
> On 18/09/17 01:03, Matthias Clasen wrote:
> > On Sun, Sep 17, 2017 at 1:12 AM, Adrian Johnson <ajohnson@redneon.com
> > <mailto:ajohnson@redneon.com>> wrote:
> > I've attached a patch that refactors the float parsing code from
> > cff-subset into a new function: _cairo_strtod(). So you can now use
> this
> > for a C locale strtod.
> >
> >
> > Yay, thanks.It might still be nice to apply the strtod_l patch on top,
> > and only use that code as fallback.
>
> -1. Just use the cairo_strtod all the time. We don't use non ANSI C
> functions with #include guarded fallbacks in cairo. It adds to source
> code bloat and one side of the #if won't get regularly tested.
>
>
I disagree, at least in this case, but your call.
>
> I'm getting a test failure running font-variations. The test log is:
>
> axis Weight, value 19660800
> axis CNTR, value 0
> Axis Weight: not expected value (19660800 != 13107200)
>
> I have tried both the otf and ttf version of the Adobe Variable Font
> Prototype v1.003. Same result for both.
>
> I'm not sure what I'm doing wrong. Could the test be sensitive to my
> fontconfig configuration? I am using Debian Stretch.
It sounds unlikely to me. Maybe Behdads fontconfig patches interfere here?
I've written the test on a system without them.
> In font-variations.c, FT_Get_Var_Design_Coordinates() will need an
> #include guard for FreeType >= 2.8.
>
[Attachment #5 (text/html)]
<div dir="ltr">On Tue, Sep 19, 2017 at 7:04 AM, Adrian Johnson <span dir="ltr"><<a \
href="mailto:ajohnson@redneon.com" \
target="_blank">ajohnson@redneon.com</a>></span> wrote:<br><div \
class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" \
style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span \
class=""><br> On 18/09/17 01:03, Matthias Clasen wrote:<br>
> On Sun, Sep 17, 2017 at 1:12 AM, Adrian Johnson <<a \
href="mailto:ajohnson@redneon.com">ajohnson@redneon.com</a><br> </span><span \
class="">> <mailto:<a \
href="mailto:ajohnson@redneon.com">ajohnson@redneon.com</a>>> wrote:<br> > \
I've attached a patch that refactors the float parsing code from<br> > \
cff-subset into a new function: _cairo_strtod(). So you can now use this<br> > \
for a C locale strtod.<br> ><br>
><br>
> Yay, thanks.It might still be nice to apply the strtod_l patch on top,<br>
> and only use that code as fallback.<br>
<br>
</span>-1. Just use the cairo_strtod all the time. We don't use non ANSI C<br>
functions with #include guarded fallbacks in cairo. It adds to source<br>
code bloat and one side of the #if won't get regularly tested.<br>
<span class=""><br></span></blockquote><div><br></div><div>I disagree, at least in \
this case, but your call.<br></div><div> </div><blockquote class="gmail_quote" \
style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span \
class=""></span><br> I'm getting a test failure running font-variations. The test \
log is:<br> <br>
axis Weight, value 19660800<br>
axis CNTR, value 0<br>
Axis Weight: not expected value (19660800 != 13107200)<br>
<br>
I have tried both the otf and ttf version of the Adobe Variable Font<br>
Prototype v1.003. Same result for both.<br>
<br>
I'm not sure what I'm doing wrong. Could the test be sensitive to my<br>
fontconfig configuration? I am using Debian \
Stretch.</blockquote><div><br></div><div>It sounds unlikely to me. Maybe Behdads \
fontconfig patches interfere here?</div><div>I've written the test on a system \
without them.</div><div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 \
.8ex;border-left:1px #ccc solid;padding-left:1ex"> <br>
In font-variations.c, FT_Get_Var_Design_Coordinates(<wbr>) will need an<br>
#include guard for FreeType >= 2.8.<br>
</blockquote></div><br></div></div>
[Attachment #6 (text/plain)]
--
cairo mailing list
cairo@cairographics.org
https://lists.cairographics.org/mailman/listinfo/cairo
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic