[prev in list] [next in list] [prev in thread] [next in thread] 

List:       amarok-bugs-dist
Subject:    [amarok] [Bug 279188] Launching amarok with --cdplay doesn't add the CD to playlist
From:       "Tuomas Nurmi" <bugzilla_noreply () kde ! org>
Date:       2024-03-29 23:44:18
Message-ID: bug-279188-71684-sz5ann2fEF () http ! bugs ! kde ! org/
[Download RAW message or body]

https://bugs.kde.org/show_bug.cgi?id=279188

Tuomas Nurmi <tuomas@norsumanageri.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|                            |https://invent.kde.org/mult
                   |                            |imedia/amarok/-/commit/212b
                   |                            |693c210f673e9dac91d4c62995e
                   |                            |30ad5ecbd
         Resolution|---                         |FIXED
             Status|CONFIRMED                   |RESOLVED

--- Comment #12 from Tuomas Nurmi <tuomas@norsumanageri.org> ---
Git commit 212b693c210f673e9dac91d4c62995e30ad5ecbd by Tuomas Nurmi.
Committed on 29/03/2024 at 23:36.
Pushed by nurmi into branch 'master'.

Fix --cdplay command line option

First, avoid touching MainWindow member variables before MainWindow is
constructed to avoid immediate segfault.

Second, don't try casting cd collection to MemoryCollection, which it doesn't
inherit (at least anymore). Casting to MediaDeviceCollection actually works.
Hard to tell since when this has been broken, but most of relevant code seems
to be last changed in 2010 or earlier, so possibly a while.
Related: bug 482463

M  +2    -2    ChangeLog
M  +8    -4    src/MainWindow.cpp

https://invent.kde.org/multimedia/amarok/-/commit/212b693c210f673e9dac91d4c62995e30ad5ecbd

-- 
You are receiving this mail because:
You are the assignee for the bug.=
[prev in list] [next in list] [prev in thread] [next in thread]