[prev in list] [next in list] [prev in thread] [next in thread] 

List:       amarok-bugs-dist
Subject:    [amarok] [Bug 327547] Last.fm Invalid session key error not handled: scrobbles silently lost until a
From:       Matěj Laitl <matej () laitl ! cz>
Date:       2013-11-18 18:33:49
Message-ID: bug-327547-71684-sjOiM0dt0d () http ! bugs ! kde ! org/
[Download RAW message or body]

https://bugs.kde.org/show_bug.cgi?id=327547

Matěj Laitl <matej@laitl.cz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEEDSINFO                   |ASSIGNED
         Resolution|WAITINGFORINFO              |---
     Ever confirmed|0                           |1

--- Comment #5 from Matěj Laitl <matej@laitl.cz> ---
(In reply to comment #4)
> Yes, if you tell me which solution to implement, as I'm not familiar at all
> with Amarok source code.
> 
> The onWsError could help catch every invalid session key error, not just the
> scrobbling, and start a re-authentication (but where should I add this code
> in amarok?)

Please add that method to class App (src/App.h/cpp), guarded by #ifdef
HAVE_LIBLASTFM. It would be a little glue that would call appropriate method in
ScrobblerAdapter.

> And  ScrobblerAdapter::slotScrobblesSubmitted could check the error and
> resubmit in case of Invalid session key, if we know the onWsError has
> already finished it's re-authentication.

No, above solution is better.

> Or we could just do a scrobbler.submit() in LastFmService::continueReconfiguring() (it does
> nothing if the cache is empty, so no network overhead in the usual flow).

Yes please (I assume continueReconfiguring() gets caller after successful
re-auth)

-- 
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Amarok-bugs-dist mailing list
Amarok-bugs-dist@kde.org
https://mail.kde.org/mailman/listinfo/amarok-bugs-dist

[prev in list] [next in list] [prev in thread] [next in thread]