[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Review Request 110042: Find Qt5 version of DBusMenuQt
From: "Frederik Gladhorn" <gladhorn () kde ! org>
Date: 2013-04-16 13:26:23
Message-ID: 20130416132623.4246.78425 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110042/
-----------------------------------------------------------
Review request for kdelibs.
Description
-------
Build fix for dbusmenu qt5 changes.
This appends the 5 to include path and lib dir in the find module.
Also rename the whole thing to not conflict with the Qt 4 version.
Diffs
-----
CMakeLists.txt 00402d4
cmake/modules/FindDBusMenuQt.cmake 5af70ef
cmake/modules/FindDBusMenuQt5.cmake PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/110042/diff/
Testing
-------
Thanks,
Frederik Gladhorn
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110042/">http://git.reviewboard.kde.org/r/110042/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Frederik Gladhorn.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Build fix for dbusmenu qt5 changes. This appends the 5 to include path \
and lib dir in the find module. Also rename the whole thing to not conflict with the \
Qt 4 version.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(00402d4)</span></li>
<li>cmake/modules/FindDBusMenuQt.cmake <span style="color: \
grey">(5af70ef)</span></li>
<li>cmake/modules/FindDBusMenuQt5.cmake <span style="color: \
grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110042/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic