[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    [Bug 164137] [PATCH] JJ: Remove "use custom titlebar button positions"
From:       Marcus Harrison <marcus () harrisonland ! co ! uk>
Date:       2009-06-22 14:41:16
Message-ID: 20090622144116.8AF9416F65 () immanuel ! kde ! org
[Download RAW message or body]

https://bugs.kde.org/show_bug.cgi?id=164137





--- Comment #24 from Marcus Harrison <marcus harrisonland co uk>  2009-06-22 16:41:13 ---
(In reply to comment #23)
> > This is why:
> > When the checkbox is checked, if I change the window decoration
> > theme, then the buttons change to what the designer thought would
> > be best for the window decoration. 
> 
> ? Nope.

Correction: when the checkbox is UNCHECKED, that behaviour is observed. I got
the two mixed up.


> 
> > So if we remove this checkbox, how should changing the window
> > decoration make the buttons behave? 
> 
> ? The changing of the deco has 0 impact on the checkbox. Checkbox simply
> _allows_ you to make the changes.
> 

The CHECKBOX has a huge impact on the behaviour of the buttons, should you
change the DECORATION, not the other way round, which is why I would keep
things the way they are.


> If you would like to customize deco, you customize, if you would like default
> deco, reset the changes. There is no need (this is important part) for the
> third party -- guard for allowing you customization. 
> 

Like I said, window decoration buttons are different to other features - if you
change the colour scheme, it doesn't change the widget style, and vice versa.
If you change the, "active desktop borders" setting, it doesn't change the,
"Window snapping" setting, etc. etc. However, if you change the window
decoration, it DOES, by default, change the buttons. This checkbox acts as an
override for power-users, therefore it should be kept.

> It is the _only_ part of systemsettings (and previously KControl) which has
> such guard. In every other place you simply do customization. Compare it to
> screensaver, plasma, fonts, colors, and so on, and so on.

See above. Changing one setting in plasma doesn't typically change another.
Window decorations are different.

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]