[prev in list] [next in list] [prev in thread] [next in thread] 

List:       konq-bugs
Subject:    [Bug 69345] [test case] links not recognised with padding
From:       Germain Garand <germain () ebooksfrance ! com>
Date:       2003-12-05 5:48:49
[Download RAW message or body]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
     
http://bugs.kde.org/show_bug.cgi?id=69345     
germain@ebooksfrance.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED



------- Additional Comments From germain@ebooksfrance.com  2003-12-05 06:48 -------
Subject: kdelibs/khtml

CVS commit by ggarand: 

- don't offset relatively positioned objects coordinates. They already are (#68716/#60453)

- no need to include borders and padding in RenderText's matching region anymore (#69345)

Acknowledged by Dirk

CCMAIL: 68716-done@bugs.kde.org, 60453-done@bugs.kde.org, 69345-done@bugs.kde.org
				


  M +9 -0      ChangeLog   1.130
  M +0 -2      rendering/render_object.cpp   1.244
  M +2 -8      rendering/render_text.cpp   1.234


--- kdelibs/khtml/ChangeLog  #1.129:1.130
@@ -1,2 +1,11 @@
+
+2003-12-05  Germain Garand  <germain@ebooksfrance.org>
+
+        * rendering/render_object.cpp (nodeAtPoint): don't offset
+        relatively positioned objects coordinates. They already are (#68716/#60453)
+
+        * rendering/render_text.cpp (nodeAtPoint): no need to include borders and padding
+        in the matching region anymore (#69345)
+
 2003-12-05  Germain Garand  <germain@ebooksfrance.org>
 

--- kdelibs/khtml/rendering/render_text.cpp  #1.233:1.234
@@ -662,10 +662,4 @@ bool RenderText::nodeAtPoint(NodeInfo& i
     assert(parent());
 
-    _tx -= paddingLeft() + borderLeft();
-    _ty -= borderTop() + paddingTop();
-
-    int height = m_lineHeight + borderTop() + paddingTop() +
-                 borderBottom() + paddingBottom();
-
     bool inside = false;
     if (style()->visibility() != HIDDEN) {
@@ -673,5 +667,5 @@ bool RenderText::nodeAtPoint(NodeInfo& i
         int si = 0;
         while(s) {
-            if((_y >=_ty + s->m_y) && (_y < _ty + s->m_y + height) &&
+            if((_y >=_ty + s->m_y) && (_y < _ty + s->m_y + s->height()) &&
                (_x >= _tx + s->m_x) && (_x <_tx + s->m_x + s->m_width) ) {
                 inside = true;

--- kdelibs/khtml/rendering/render_object.cpp  #1.243:1.244
@@ -1312,6 +1312,4 @@ bool RenderObject::nodeAtPoint(NodeInfo&
     int tx = _tx + xPos();
     int ty = _ty + yPos();
-    if (isRelPositioned())
-        static_cast<RenderBox*>(this)->relativePositionOffset(tx, ty);
 
     inside |= ( style()->visibility() != HIDDEN &&
_______________________________________________
Konq-bugs mailing list
Konq-bugs@mail.kde.org
https://mail.kde.org/mailman/listinfo/konq-bugs
[prev in list] [next in list] [prev in thread] [next in thread]