[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    Re: Bug#2755: konqy: "forward" & "back" toolbar button remain depressed (sunken)
From:       Dawit Alemayehu <adawit () earthlink ! net>
Date:       2000-02-28 21:22:30
[Download RAW message or body]

On Sat, 26 Feb 2000, Dawit Alemayehu wrote:
> On Sat, 26 Feb 2000, David Faure wrote:
> > On Sat, Feb 26, 2000 at 09:50:01PM -0500, Dawit Alemayehu wrote:
> > > On Sat, 26 Feb 2000, Claudiu Costin wrote:
> > > > Package: konqueror
> > > > Version: 17.02.2000
> > > > 
> > > > 1) make a dir "a1" and "cd a1" (from konqy :)
> > > > 2) make a dir "a2" and "cd a2"
> > > > 3) press "Back" toolbar button and keep it until
> > > > history list apear. Then choose, e.g. /home/worker/a1.
> > > > 
> > > >   You will observe that "back" button remain depressed (sunken)
> > > > When clic on it sometimes, state will be again correct.
> > > > This problem happen for "Forward" either.
> > > 
> > > Fixed this two days ago.  Are you using a current snapshot ?
> > 
> > Dawit, please try the exact thing described here : selecting
> > a menu item from the dropdown list.
> > I'm using the current version, and the button remains pressed
> > after selecting an item.
> > 
> > I think you fixed un-pressing the button when clicking anywhere
> > else (cancelling the popup menu), not when actually selecting a URL in
> > the popup menu.
> 
> I bet you I moved the correct code by mistake when testing *sigh*.  Will fix as
> soon as I get my system in order ( read:couple of hours ).  HD got trashed :((
> Currently recovering ...
> 
> > Thanks for fixing again :)
> 
> No problem.  I caused the problem to begin with anyway :)

David,  I just looked at this today when I finally recovered my HD.  I cannot
duplicate it.  If you press and hold until the button sticks and click on the
popup menu items or anywhere else for that matter, the button returns to its
normal state ( becomes un-depressed).  I tried several ways but I could not
duplicate the problem.  BTW,  the fix for it was in kdelibs/kdeui/ktoolbarbutton.cpp
and not in kdebase.  Were you using a recent kdelibs ( you probably are but
I just thought I ask ) ?  I just checked to make sure my patch was commited and
it was...

=============================================================================   
RCS file: /home/kde/kdelibs/kdeui/ktoolbarbutton.cpp,v
Working file: ktoolbarbutton.cpp
head: 1.8
branch:
locks: strict
access list:
symbolic names:
        KDE_2_0_pre_alpha_KRASH: 1.4
keyword substitution: kv
total revisions: 8;     selected revisions: 1
description:
----------------------------
revision 1.8
date: 2000/02/24 08:48:53;  author: adawit;  state: Exp;  lines: +7 -2
Fixed a nasty side effect when toggling is enbled for delayed popup menu.
The button never returned to normal mode when it was pressed, dragged
and the mouse was released outside of its geometry. (DA)
=============================================================================   

Cheers,
Dawit A.

[prev in list] [next in list] [prev in thread] [next in thread]