[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kdelibs-bugs
Subject:    [frameworks-kdoctools] [Bug 379142] kdoctools fails when linking.
From:       Luigi Toscano <bugzilla_noreply () kde ! org>
Date:       2017-05-02 18:14:19
Message-ID: bug-379142-90985-MT8FNBF72Z () http ! bugs ! kde ! org/
[Download RAW message or body]

https://bugs.kde.org/show_bug.cgi?id=379142

Luigi Toscano <luigi.toscano@tiscali.it> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CONFIRMED                   |RESOLVED
      Latest Commit|                            |https://commits.kde.org/kdo
                   |                            |ctools/86c5dd3baa3c4483fed1
                   |                            |cea8fc140c18a9c27d0d
         Resolution|---                         |FIXED

--- Comment #5 from Luigi Toscano <luigi.toscano@tiscali.it> ---
Git commit 86c5dd3baa3c4483fed1cea8fc140c18a9c27d0d by Luigi Toscano.
Committed on 02/05/2017 at 18:14.
Pushed by ltoscano into branch 'master'.

Solve a visibility conflict for meinproc5

Summary:
This seems to affect only mingw, which can't link meinproc5 as
the symbol exported affects in the sources shared with the
library affects the build (but not on gcc on *nix and with MSVC).

The other (probably better) solution would have been to split the
source code so that the sources of the libraries are separate, but
that would require more changes. As this seems to work, I'd prefer
to move the more complicated changes to "later".

Thanks to Hannah Von Reth for the hint.

Test Plan: Compiles with gcc 6.3 (Debian Testing), as before), with mingw (as
deployed on current Craft) and with MSVC (2017) (the latter with less linking
warnings so it was an issue there). All on x86_64.

Reviewers: vonreth

Reviewed By: vonreth

Subscribers: #frameworks, #documentation

Tags: #frameworks, #documentation, #windows

Differential Revision: https://phabricator.kde.org/D5674

M  +1    -0    src/CMakeLists.txt

https://commits.kde.org/kdoctools/86c5dd3baa3c4483fed1cea8fc140c18a9c27d0d

-- 
You are receiving this mail because:
You are on the CC list for the bug.=
[prev in list] [next in list] [prev in thread] [next in thread]