[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kdelibs-bugs
Subject:    [frameworks-solid] [Bug 345871] Solid::Backends::UDisks2::DeviceBackend::checkCache() causes crash a
From:       David Edmundson <bugzilla_noreply () kde ! org>
Date:       2017-01-30 12:15:55
Message-ID: bug-345871-90985-pOUl8Jl1IW () http ! bugs ! kde ! org/
[Download RAW message or body]

https://bugs.kde.org/show_bug.cgi?id=345871

David Edmundson <kde@davidedmundson.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CONFIRMED                   |RESOLVED
      Latest Commit|                            |https://commits.kde.org/sol
                   |                            |id/6f1c6dc84a3dbfc0b14946a5
                   |                            |2e84df49fc63f327
         Resolution|---                         |FIXED

--- Comment #44 from David Edmundson <kde@davidedmundson.co.uk> ---
Git commit 6f1c6dc84a3dbfc0b14946a52e84df49fc63f327 by David Edmundson.
Committed on 30/01/2017 at 12:15.
Pushed by davidedmundson into branch 'master'.

Work round DBus property fetching bug

Summary:
property() works in a slightly different way to just calling Get().
It allocates the variant of the relevant type in advance in QObject
code, and then calls
the DBus code to populate it.

This fails for QByteArrayList, before it reaches DBus code.
I don't know why, but we need a wokraround in Solid anyway.

>From a DBus traffic perspective this code is identical, we just avoid
going through Qt properties.

This shouldn't introduce any new bugs, as we already use GetAll
directly, if anything this brings it more
in line.

Test Plan:
Commented out the checkCache so that it always loads data.
Instead of failing, it now works.

Subscribers: #frameworks

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D4305

M  +13   -9    src/solid/devices/backends/udisks2/udisksdevicebackend.cpp

https://commits.kde.org/solid/6f1c6dc84a3dbfc0b14946a52e84df49fc63f327

-- 
You are receiving this mail because:
You are on the CC list for the bug.=
[prev in list] [next in list] [prev in thread] [next in thread]