[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-release-team
Subject: Re: Review Request 128224: remove json, appdata and mimetype pos from frameworks tarball
From: Burkhard_Lück <lueck () hube-lueck ! de>
Date: 2016-11-21 20:54:28
Message-ID: 20161121205428.32069.61877 () mimi ! kde ! org
[Download RAW message or body]
--===============1784151421997436859==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
> On Nov. 20, 2016, 4:57 nachm., David Faure wrote:
> > I just realized that this change was in fact a no-op. pack_l10n.sh isn't used \
> > when releasing frameworks (it's the script that makes the separate l10n tarballs, \
> > when releasing applications). I'll remove it from the frameworks branch of \
> > release-tools to remove confusion. This means you probably need to revisit this. \
> > The l10n stuff is done in update_l10n.sh and make_rc_tag.sh Sorry for not \
> > noticing earlier.
make_rc_tag.sh takes the catalog names from the extraction targets in the Messages.sh \
files and does not pick up json, appdata and mimetype catalogs, so only the necessary \
po files are included in the frameworks tarballs.
- Burkhard
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128224/#review100971
-----------------------------------------------------------
On Juni 17, 2016, 8:27 nachm., Burkhard Lück wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128224/
> -----------------------------------------------------------
>
> (Updated Juni 17, 2016, 8:27 nachm.)
>
>
> Review request for Release Team and David Faure.
>
>
> Repository: release-tools
>
>
> Description
> -------
>
> see summary
>
> would make sense to share some common stuff between applications + frameworks
>
>
> Diffs
> -----
>
> pack_l10n.sh 2ba5dc5
>
> Diff: https://git.reviewboard.kde.org/r/128224/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Burkhard Lück
>
>
--===============1784151421997436859==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128224/">https://git.reviewboard.kde.org/r/128224/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On November 20th, 2016, 4:57 nachm. UTC, <b>David \
Faure</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I just realized that this change was in fact a no-op. \
pack_l10n.sh isn't used when releasing frameworks (it's the script that makes the \
separate l10n tarballs, when releasing applications). I'll remove it from the \
frameworks branch of release-tools to remove confusion. This means you probably need \
to revisit this. The l10n stuff is done in update_l10n.sh and make_rc_tag.sh Sorry \
for not noticing earlier.</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">make_rc_tag.sh takes the catalog names from the extraction targets in the \
Messages.sh files and does not pick up json, appdata and mimetype catalogs, so only \
the necessary po files are included in the frameworks tarballs.</p></pre> <br />
<p>- Burkhard</p>
<br />
<p>On Juni 17th, 2016, 8:27 nachm. UTC, Burkhard Lück wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Release Team and David Faure.</div>
<div>By Burkhard Lück.</div>
<p style="color: grey;"><i>Updated Juni 17, 2016, 8:27 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
release-tools
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">see summary</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">would make sense to \
share some common stuff between applications + frameworks</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>pack_l10n.sh <span style="color: grey">(2ba5dc5)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128224/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============1784151421997436859==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic