[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-release-team
Subject: Re: Review Request 125565: KMail: Fix scrolling up/down on the message viewer
From: "Albert Astals Cid" <aacid () kde ! org>
Date: 2015-10-09 12:31:48
Message-ID: 20151009123148.17685.59651 () mimi ! kde ! org
[Download RAW message or body]
--===============5836628491770167067==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125565/
-----------------------------------------------------------
(Updated Oct. 9, 2015, 12:31 p.m.)
Status
------
This change has been marked as submitted.
Review request for KDEPIM and Release Team.
Changes
-------
Submitted with commit 9d52b22b3652f4dc274114f41c6ea83a31477c01 by Albert Astals Cid \
to branch Applications/15.08.
Repository: kdepim
Description
-------
The new style connection for signals does not support default arguments so
connect(mScrollUpAction, &QAction::triggered,
q, &Viewer::slotScrollUp);
Connects the version of triggered(bool) with slotScrollUp meaning that slotScrollUp \
always gets a 0 since the action is never checked.
This breaks the API but the widget is only used internally so i think it's something \
we can live on.
Release-team can we sneak this onto 15.0.8.2 since it's relatively critical?
kdepim guys is there a bug number for this?
Diffs
-----
messageviewer/viewer/viewer.h 150c24b
messageviewer/viewer/viewer.cpp ea4fa75
Diff: https://git.reviewboard.kde.org/r/125565/diff/
Testing
-------
WOOOOOOOOOOOOORKS
Thanks,
Albert Astals Cid
--===============5836628491770167067==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125565/">https://git.reviewboard.kde.org/r/125565/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDEPIM and Release Team.</div>
<div>By Albert Astals Cid.</div>
<p style="color: grey;"><i>Updated Oct. 9, 2015, 12:31 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit 9d52b22b3652f4dc274114f41c6ea83a31477c01 by Albert \
Astals Cid to branch Applications/15.08.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdepim
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">The new style connection for signals does not support \
default arguments so </p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">connect(mScrollUpAction, \
&QAction::triggered, q, &Viewer::slotScrollUp);</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Connects the version of triggered(bool) with \
slotScrollUp meaning that slotScrollUp always gets a 0 since the action is never \
checked.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This breaks the API but the widget is only used \
internally so i think it's something we can live on.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Release-team can we sneak this onto 15.0.8.2 since it's relatively \
critical?</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">kdepim guys is there a bug number for this?</p></pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">WOOOOOOOOOOOOORKS</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>messageviewer/viewer/viewer.h <span style="color: grey">(150c24b)</span></li>
<li>messageviewer/viewer/viewer.cpp <span style="color: grey">(ea4fa75)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125565/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============5836628491770167067==--
[Attachment #3 (text/plain)]
_______________________________________________
release-team mailing list
release-team@kde.org
https://mail.kde.org/mailman/listinfo/release-team
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic