[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-kafka
Subject:    Re: [PATCH] lists for kafka
From:       Emmanuel Touzery <emmanuel.touzery () wanadoo ! fr>
Date:       2001-05-26 22:37:52
[Download RAW message or body]

On Thursday 24 May 2001 09:43, Nikolas Zimmermann wrote:
> hmm sorry i'm off for sailing in the netherlands until
> sunday, could you rework your patch to use
> part()->insertElement()
>
> important for KafkaHistory & co

argh, it should be very easy, unfortunately i'm in exams right now and have 
not so much time (and i deleted my tree here when you said you applied, don't 
know how to get a tree back with cvs patches, don't have time to look into it 
for now).

BUT i looked into insertElement() and i'm not too happy of the code:

try
    {
	parentNode.insertBefore(pNode, currentNode.nextSibling());
    }
    catch(DOM::DOMException de)
    {
    	kdDebug(25001) << "Exception " << de.code << " occured." << endl;
	try
	{
	    currentNode.appendChild(pNode);
	}
..

i would rather put:

if (currentNode.nextSibling().isNull())
	    currentNode.appendChild(pNode);
else
	parentNode.insertBefore(pNode, currentNode.nextSibling());

it works, i have that all over my code..

please change that..

> Bye
>  Bye
>   Niko
>
> > :) (removed the imp file)

cool, tried to do so, g++ was complaining about inheriting QObject  and all 
(obviously talking about moc's generated code), so i did NOT want to look 
there ;o)

ok, if you wait till monday evening, i can do that still (but if you can tell 
me how to get my tree back from the patches it'd be great :o) ).

sorry about that... enjoy sailing, i'll try to enjoy my exams ;o)

emmanuel :o)
-- 
Better give your hours some more life
than your life some more hours. 
	- anonymous
_______________________________________________
Kde-kafka mailing list
Kde-kafka@master.kde.org
http://master.kde.org/mailman/listinfo/kde-kafka

[prev in list] [next in list] [prev in thread] [next in thread]