[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu-devel
Subject: D22507: Tooltip Framework for m_statsTable in HypothesisTestView
From: Alexander Semke <noreply () phabricator ! kde ! org>
Date: 2019-07-28 19:43:04
Message-ID: e747cae2d90bb1b25934f5282d01d4e4 () localhost ! localdomain
[Download RAW message or body]
[Attachment #2 (text/plain)]
asemke added inline comments.
INLINE COMMENTS
> devanshuagarwal wrote in HypothesisTest.cpp:1578
> No, I don't think that can be done. Because when the user clicks on the word, the \
> information we get is the global position and data of the selected word. While \
> creating the map we didn't know apriori the global position of the word where the \
> tooltip is to be set.
> So, to avoid collisions, we have to work on getting the global position of each \
> word apriori.
I didn't refer to the word or to the global position. My suggestion was to create in \
Cell::Cell() an unique identifier (use a random number maybe) and use it via \
cell-id() as the key in the map.
> devanshuagarwal wrote in HypothesisTest.h:85
> Ok, I had done removed pointer from tooltips as I also found it unnecessary. Now, \
> for all pointers I created, I have deleted them.
What I meant was use QMap<QString, QString> tooltips instead of QMap<QString, \
QString>* tooltips.
> devanshuagarwal wrote in HypothesisTestPrivate.h:103
> Yes, I am using that only to actually the function definition is:
>
> bool GeneralTest::isNumericOrInteger(const Column* column) {
> return (column->columnMode() == AbstractColumn::Numeric || column->columnMode() == \
> AbstractColumn::Integer); }
>
> Its is just that this is used many times in code so I wanted to use something \
> short. Is using macro for this purpose more appropriate?
instead of this function you can simply use column->isNumeric().
REPOSITORY
R262 LabPlot
REVISION DETAIL
https://phabricator.kde.org/D22507
To: devanshuagarwal, sgerlach, asemke
Cc: kde-edu, narvaez, apol
[Attachment #3 (text/html)]
<table><tr><td style="">asemke added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D22507">View Revision</a></tr></table><br \
/><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D22507#inline-128705">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">devanshuagarwal</span> wrote in <span \
style="color: #4b4d51; font-weight: bold;">HypothesisTest.cpp:1578</span></div> <div \
style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: \
8px;">No, I don't think that can be done. Because when the user clicks on the \
word, the information we get is the global position and data of the selected word. \
While creating the map we didn't know apriori the global position of the word \
where the tooltip is to be set.</p>
<p style="padding: 0; margin: 8px;">So, to avoid collisions, we have to work on \
getting the global position of each word apriori.</p></div></div> <div style="margin: \
8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I didn't refer to \
the word or to the global position. My suggestion was to create in Cell::Cell() an \
unique identifier (use a random number maybe) and use it via cell-id() as the key in \
the map.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D22507#inline-128704">View \
Inline</a><span style="color: #4b4d51; font-weight: bold;">devanshuagarwal</span> \
wrote in <span style="color: #4b4d51; font-weight: \
bold;">HypothesisTest.h:85</span></div> <div style="margin: 8px 0; padding: 0 12px; \
color: #74777D;"><p style="padding: 0; margin: 8px;">Ok, I had done removed pointer \
from tooltips as I also found it unnecessary. Now, for all pointers I created, I have \
deleted them.</p></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p \
style="padding: 0; margin: 8px;">What I meant was use QMap<QString, QString> \
tooltips instead of QMap<QString, QString>* tooltips.</p></div></div><br /><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D22507#inline-128706">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">devanshuagarwal</span> wrote in <span \
style="color: #4b4d51; font-weight: bold;">HypothesisTestPrivate.h:103</span></div> \
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; \
margin: 8px;">Yes, I am using that only to actually the function definition is:</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" \
data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px \
"Menlo", "Consolas", "Monaco", monospace; padding: \
12px; margin: 0; background: rgba(71, 87, 120, 0.08);">bool \
GeneralTest::isNumericOrInteger(const Column* column) { return \
(column->columnMode() == AbstractColumn::Numeric || column->columnMode() == \
AbstractColumn::Integer); }</pre></div>
<p style="padding: 0; margin: 8px;">Its is just that this is used many times in code \
so I wanted to use something short. <br /> Is using macro for this purpose more \
appropriate?</p></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p \
style="padding: 0; margin: 8px;">instead of this function you can simply use \
column->isNumeric().</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R262 LabPlot</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D22507">https://phabricator.kde.org/D22507</a></div></div><br \
/><div><strong>To: </strong>devanshuagarwal, sgerlach, asemke<br /><strong>Cc: \
</strong>kde-edu, narvaez, apol<br /></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic