[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    D19245: leftright activity layout issues fixed
From:       Johnny Jazeix <noreply () phabricator ! kde ! org>
Date:       2019-02-24 9:38:16
Message-ID: a41d29cbea011b60b43dd45f7ab89592 () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

jjazeix closed this revision.
jjazeix added a comment.


  committed in https://commits.kde.org/gcompris/e185c82d21879412ef448ab838655699fb340937 \
with some changes

INLINE COMMENTS

> Leftright.qml:73
> anchors.top: topBorder.bottom
> +            anchors.topMargin: 20
> fillMode: Image.PreserveAspectFit

hardcoding a value is never good when you have the possibility to use anchors.
Here, you want to have the blackboard below the score, so let's just put the score \
bottom as blackboard top anchor.

REPOSITORY
  R2 GCompris

REVISION DETAIL
  https://phabricator.kde.org/D19245

To: dekumar, #gcompris_improvements, timotheegiet
Cc: jjazeix, timotheegiet, echarruau, kde-edu, narvaez, apol


[Attachment #3 (text/html)]

<table><tr><td style="">jjazeix closed this revision.<br />jjazeix added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D19245">View Revision</a></tr></table><br \
/><div><div><p>committed in <a \
href="https://commits.kde.org/gcompris/e185c82d21879412ef448ab838655699fb340937" \
class="remarkup-link" target="_blank" \
rel="noreferrer">https://commits.kde.org/gcompris/e185c82d21879412ef448ab838655699fb340937</a> \
with some changes</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D19245#inline-107570">View \
Inline</a><span style="color: #4b4d51; font-weight: \
bold;">Leftright.qml:73</span></div> <div style="font: 11px/15px &quot;Menlo&quot;, \
&quot;Consolas&quot;, &quot;Monaco&quot;, monospace; white-space: pre-wrap; clear: \
both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">       \
<span style="color: #aa4000">anchors.top:</span> <span style="color: \
#004012">topBorder</span><span class="p">.</span><span style="color: \
#004012">bottom</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(151, 234, 151, .6);">            <span style="color: \
#aa4000">anchors.topMargin:</span> <span style="color: #601200">20</span> </div><div \
style="padding: 0 8px; margin: 0 4px; ">            <span style="color: \
#aa4000">fillMode:</span> <span style="color: #004012">Image</span><span \
class="p">.</span><span style="color: #004012">PreserveAspectFit</span> \
</div></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; \
margin: 8px;">hardcoding a value is never good when you have the possibility to use \
anchors.<br /> Here, you want to have the blackboard below the score, so let&#039;s \
just put the score bottom as blackboard top \
anchor.</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R2 GCompris</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D19245">https://phabricator.kde.org/D19245</a></div></div><br \
/><div><strong>To: </strong>dekumar, GCompris: Improvements, timotheegiet<br \
/><strong>Cc: </strong>jjazeix, timotheegiet, echarruau, kde-edu, narvaez, apol<br \
/></div>



[prev in list] [next in list] [prev in thread] [next in thread]