[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    D17626: [WIP] Print preview for KmPlot
From:       Yuri Chornoivan <noreply () phabricator ! kde ! org>
Date:       2018-12-16 16:21:25
Message-ID: 9189c21a720b4fa3809b2d6559f352a9 () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

yurchor created this revision.
yurchor added a reviewer: KDE Edu.
Herald added a project: KDE Edu.
Herald added a subscriber: kde-edu.
yurchor requested review of this revision.

REVISION SUMMARY
  A bit ugly attempt to implement print preview with an additional configuration \
widget.  
  F6480632: print_prev.png <https://phabricator.kde.org/F6480632>

TEST PLAN
  1. Plot something.
  2. Choose "File -> Print Preview"
  3. Press the last button on the toolbar to configure the print options.
  4. Due to the obvious inability to repaint the image from the current code, no \
print preview update occurs after pressing the "Ok" button.  5. Choose some other \
option (switch to the landscape mode and back). The preview should be updated with \
the parameters chosen on step 3.  
  I need an advice on the quality of the code and how the update can be triggered in \
the right way (google only advices to trigger it in a programmatical way of pressing \
buttons on the toolbar that is surely unacceptable).  
  Many thanks in advance for your reviews.

REPOSITORY
  R334 KmPlot

REVISION DETAIL
  https://phabricator.kde.org/D17626

AFFECTED FILES
  kmplot/kmplot_part.rc
  kmplot/maindlg.cpp
  kmplot/maindlg.h

To: yurchor, #kde_edu
Cc: kde-edu, narvaez, apol


[Attachment #3 (text/html)]

<table><tr><td style="">yurchor created this revision.<br />yurchor added a reviewer: \
KDE Edu.<br />Herald added a project: KDE Edu.<br />Herald added a subscriber: \
kde-edu.<br />yurchor requested review of this revision. </td><a \
style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; \
color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; \
background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; \
border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D17626">View \
Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>A bit \
ugly attempt to implement print preview with an additional configuration widget.</p>

<p><a href="https://phabricator.kde.org/F6480632" style="background-color: #e7e7e7;
          border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;">F6480632: \
print_prev.png</a></p></div></div><br /><div><strong>TEST PLAN</strong><div><ol \
class="remarkup-list"> <li class="remarkup-list-item">Plot something.</li>
<li class="remarkup-list-item">Choose &quot;File -&gt; Print Preview&quot;</li>
<li class="remarkup-list-item">Press the last button on the toolbar to configure the \
print options.</li> <li class="remarkup-list-item">Due to the obvious inability to \
repaint the image from the current code, no print preview update occurs after \
pressing the &quot;Ok&quot; button.</li> <li class="remarkup-list-item">Choose some \
other option (switch to the landscape mode and back). The preview should be updated \
with the parameters chosen on step 3.</li> </ol>

<p>I need an advice on the quality of the code and how the update can be triggered in \
the right way (google only advices to trigger it in a programmatical way of pressing \
buttons on the toolbar that is surely unacceptable).</p>

<p>Many thanks in advance for your reviews.</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R334 KmPlot</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D17626">https://phabricator.kde.org/D17626</a></div></div><br \
/><div><strong>AFFECTED FILES</strong><div><div>kmplot/kmplot_part.rc<br /> \
kmplot/maindlg.cpp<br /> kmplot/maindlg.h</div></div></div><br /><div><strong>To: \
</strong>yurchor, KDE Edu<br /><strong>Cc: </strong>kde-edu, narvaez, apol<br \
/></div>



[prev in list] [next in list] [prev in thread] [next in thread]