'Re: Review Request 127441: Fix never ending event loop when quitting app and segmentation faults'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    Re: Review Request 127441: Fix never ending event loop when quitting app and segmentation faults
From:       Hartmut Riesenbeck <hartmut.riesenbeck () gmx ! de>
Date:       2016-03-25 20:40:42
Message-ID: 20160325204042.3064.60180 () mimi ! kde ! org
[Download RAW message or body]

--===============3962393090873756788==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127441/
-----------------------------------------------------------

(Updated March 25, 2016, 8:40 p.m.)

Status
------

This change has been marked as submitted.

Review request for KDE Edu.

Changes
-------

Submitted with commit 1ecfb75bdddc176cd8837d39935329fd02b9f910 by Hartmut Riesenbeck \
to branch Applications/16.04.

Repository: parley

Description
-------

When the app is quited app.exec() doesn't return. The process stays in
sleeping state. Removed app.setQuitOnLastWindowClosed(false) because
the quit() or exec() method of the application were not invoked
somewhere else in the application.

After this the app ends in the correct way. But after quit is invoked,
there are sporadic segmentation faults and the following message was
shown on stderr:
    QCoreApplication::postEvent: Unexpected null receiver
This was fixed by removing zero pointer access in destuctor of
ParleyDocument.

Added missing this pointer on KEduVocDocument allocation.

Diffs
-----

  src/main.cpp 2e87baa93f81349a187d620be2468f8a1bb4aca1 
  src/parleydocument.cpp cf4c81c3f8f35a99389d61a75d934cff3170b960 
  src/parleymainwindow.cpp d6f86debd32c1e77bbcca86a160906674960dce9 

Diff: https://git.reviewboard.kde.org/r/127441/diff/

Testing
-------

Thanks,

Hartmut Riesenbeck

--===============3962393090873756788==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/127441/">https://git.reviewboard.kde.org/r/127441/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Edu.</div>
<div>By Hartmut Riesenbeck.</div>

<p style="color: grey;"><i>Updated March 25, 2016, 8:40 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit 1ecfb75bdddc176cd8837d39935329fd02b9f910 by \
Hartmut Riesenbeck to branch Applications/16.04.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
parley
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">When the app is quited app.exec() doesn't return. The \
process stays in sleeping state. Removed app.setQuitOnLastWindowClosed(false) because
the quit() or exec() method of the application were not invoked
somewhere else in the application.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">After this the app ends in the correct way. But after \
quit is invoked, there are sporadic segmentation faults and the following message was
shown on stderr:
    QCoreApplication::postEvent: Unexpected null receiver
This was fixed by removing zero pointer access in destuctor of
ParleyDocument.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Added missing this pointer on KEduVocDocument \
allocation.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/main.cpp <span style="color: \
grey">(2e87baa93f81349a187d620be2468f8a1bb4aca1)</span></li>

 <li>src/parleydocument.cpp <span style="color: \
grey">(cf4c81c3f8f35a99389d61a75d934cff3170b960)</span></li>

 <li>src/parleymainwindow.cpp <span style="color: \
grey">(d6f86debd32c1e77bbcca86a160906674960dce9)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/127441/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============3962393090873756788==--

[Attachment #3 (text/plain)]

_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu

[prev in list] [next in list] [prev in thread] [next in thread] 