'Re: Review Request 116041: Allow images to be used instead of words in flashcard practice'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    Re: Review Request 116041: Allow images to be used instead of words in flashcard practice
From:       "Inge Wallin" <inge () lysator ! liu ! se>
Date:       2014-02-25 9:55:00
Message-ID: 20140225095500.20335.58426 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116041/
-----------------------------------------------------------

(Updated Feb. 25, 2014, 9:55 a.m.)

Status
------

This change has been marked as submitted.

Review request for KDE Edu and Amarvir Singh.

Repository: parley

Description
-------

This patch implements wish 281120 - wish: ability to use only image for a "language"

The point of it is to be able to use the flashcard implementation in Parley to train \
other things than languages.  Naval buoys are mentioned in the wish but there are \
many things that could be learned using images: flags, geography, presidents, etc.

Note: There is a configuration checkbox to allow this, but that is not yet connected \
to any code. The reason for that is that there are several other checkboxes that are \
also not connected to any code.  This has to be taken care of, of course, but we need \
to get this patch in today before the string freeze.

Aside from the configuration the code works as expected even though we should \
probably increase the image size in the flashcard.

Diffs
-----

  TODO 6a75001 
  src/configure-practice/advancedpracticeoptions.ui 87a2a6a 
  src/practice/abstractbackendmode.cpp 25a97cb 
  src/practice/entryfilter.cpp a3afe84 
  src/practice/flashcardmodewidget.cpp e578153 
  src/settings/parley.kcfg 867819f 

Diff: https://git.reviewboard.kde.org/r/116041/diff/

Testing
-------

Checked using a test file that I created.

Thanks,

Inge Wallin

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/116041/">https://git.reviewboard.kde.org/r/116041/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;">  <tr>
  <td>
   <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KDE Edu and Amarvir Singh.</div>
<div>By Inge Wallin.</div>

<p style="color: grey;"><i>Updated Feb. 25, 2014, 9:55 a.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
parley
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch implements wish 281120 - wish: ability to use only image for \
a &quot;language&quot;

The point of it is to be able to use the flashcard implementation in Parley to train \
other things than languages.  Naval buoys are mentioned in the wish but there are \
many things that could be learned using images: flags, geography, presidents, etc.

Note: There is a configuration checkbox to allow this, but that is not yet connected \
to any code. The reason for that is that there are several other checkboxes that are \
also not connected to any code.  This has to be taken care of, of course, but we need \
to get this patch in today before the string freeze.

Aside from the configuration the code works as expected even though we should \
probably increase the image size in the flashcard.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Checked using a test file that I created.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>TODO <span style="color: grey">(6a75001)</span></li>

 <li>src/configure-practice/advancedpracticeoptions.ui <span style="color: \
grey">(87a2a6a)</span></li>

 <li>src/practice/abstractbackendmode.cpp <span style="color: \
grey">(25a97cb)</span></li>

 <li>src/practice/entryfilter.cpp <span style="color: grey">(a3afe84)</span></li>

 <li>src/practice/flashcardmodewidget.cpp <span style="color: \
grey">(e578153)</span></li>

 <li>src/settings/parley.kcfg <span style="color: grey">(867819f)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/116041/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu

[prev in list] [next in list] [prev in thread] [next in thread] 