[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    Re: [kde-edu]: Patch for KTouch - unsure
From:       Anne-Marie Mahfouf <annemarie.mahfouf () free ! fr>
Date:       2006-10-11 18:27:56
Message-ID: 200610112027.56760.annemarie.mahfouf () free ! fr
[Download RAW message or body]

Hi,

Thanks for reviewing, Albert! I thought it smelled fishy but I could not point 
where. 
I'll leave that at it was for the moment, it'll probably need rewriting. 

Anne-Marie

On Wednesday 11 October 2006 19:39, Albert Astals Cid wrote:
> A Dimecres 11 Octubre 2006 15:10, Anne-Marie Mahfouf va escriure:
> > Hi,
> >
> > I made a patch for KTouch (KDE4) to try to remove a few deprecated
> > methods. However I am unsure if it is the correct way as I changed
> > iterators use for index use.
> > Could someone review it before I commit? Thanks in advance.
>
> Patch is wrong, find returned end() when not found indexOf returns -1 when
> not found so you should not compare against size()-1
>
> > Also the menubar does not show in ktouch kde4, can someone confirm or is
> > it a local problem?
>
> I can confirm theres no menubar here either.
>
> Albert
>
> > Thanks in advance,
> >
> > Anne-Marie
>
> _______________________________________________
> kde-edu mailing list
> kde-edu@mail.kde.org
> https://mail.kde.org/mailman/listinfo/kde-edu
_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
[prev in list] [next in list] [prev in thread] [next in thread]