[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [labplot] src/kdefrontend/datasources: Minor fixes.
From:       Fabian Kristof <null () kde ! org>
Date:       2018-07-31 21:28:21
Message-ID: E1fkcBp-0005wE-VZ () code ! kde ! org
[Download RAW message or body]

Git commit 5fba8e1309c1b17355945f502d95d9f48c511fd7 by Fabian Kristof.
Committed on 31/07/2018 at 21:28.
Pushed by fkristof into branch 'master'.

Minor fixes.

M  +1    -1    src/kdefrontend/datasources/HDF5OptionsWidget.cpp
M  +1    -1    src/kdefrontend/datasources/HDF5OptionsWidget.h
M  +1    -1    src/kdefrontend/datasources/ROOTOptionsWidget.cpp
M  +1    -1    src/kdefrontend/datasources/ROOTOptionsWidget.h

https://commits.kde.org/labplot/5fba8e1309c1b17355945f502d95d9f48c511fd7

diff --git a/src/kdefrontend/datasources/HDF5OptionsWidget.cpp \
b/src/kdefrontend/datasources/HDF5OptionsWidget.cpp index ebdf9b6b..0352d08f 100644
--- a/src/kdefrontend/datasources/HDF5OptionsWidget.cpp
+++ b/src/kdefrontend/datasources/HDF5OptionsWidget.cpp
@@ -60,7 +60,7 @@ void HDF5OptionsWidget::clear() {
 	ui.twPreview->clear();
 }
 
-void HDF5OptionsWidget::updateContent(HDF5Filter *filter, QString fileName) {
+void HDF5OptionsWidget::updateContent(HDF5Filter *filter, const QString& fileName) {
 	ui.twContent->clear();
 	QTreeWidgetItem *rootItem = ui.twContent->invisibleRootItem();
 	filter->parse(fileName, rootItem);
diff --git a/src/kdefrontend/datasources/HDF5OptionsWidget.h \
b/src/kdefrontend/datasources/HDF5OptionsWidget.h index 71554155..4ec92a94 100644
--- a/src/kdefrontend/datasources/HDF5OptionsWidget.h
+++ b/src/kdefrontend/datasources/HDF5OptionsWidget.h
@@ -39,7 +39,7 @@ class HDF5OptionsWidget : public QWidget {
 public:
 	explicit HDF5OptionsWidget(QWidget*, ImportFileWidget*);
 	void clear();
-	void updateContent(HDF5Filter*, QString fileName);
+	void updateContent(HDF5Filter*, const QString &fileName);
 	const QStringList selectedHDF5Names() const;
 	int lines() const { return ui.sbPreviewLines->value(); }
 	QTableWidget* previewWidget() const { return ui.twPreview; }
diff --git a/src/kdefrontend/datasources/ROOTOptionsWidget.cpp \
b/src/kdefrontend/datasources/ROOTOptionsWidget.cpp index 222c5723..b52c938a 100644
--- a/src/kdefrontend/datasources/ROOTOptionsWidget.cpp
+++ b/src/kdefrontend/datasources/ROOTOptionsWidget.cpp
@@ -44,7 +44,7 @@ void ROOTOptionsWidget::clear() {
 	ui.twPreview->clearContents();
 }
 
-void ROOTOptionsWidget::updateContent(ROOTFilter *filter, QString fileName) {
+void ROOTOptionsWidget::updateContent(ROOTFilter *filter, const QString& fileName) {
 	DEBUG("updateContent()");
 	ui.lwContent->clear();
 	ui.lwContent->addItems(filter->listHistograms(fileName));
diff --git a/src/kdefrontend/datasources/ROOTOptionsWidget.h \
b/src/kdefrontend/datasources/ROOTOptionsWidget.h index 86dc74f6..73410b83 100644
--- a/src/kdefrontend/datasources/ROOTOptionsWidget.h
+++ b/src/kdefrontend/datasources/ROOTOptionsWidget.h
@@ -41,7 +41,7 @@ public:
 	explicit ROOTOptionsWidget(QWidget*, ImportFileWidget*);
 	void clear();
 	/// Fill the list of available histograms
-	void updateContent(ROOTFilter* filter, QString fileName);
+	void updateContent(ROOTFilter* filter, const QString &fileName);
 	/// Return a list of selected histograms
 	const QStringList selectedROOTNames() const;
 	int lines() const { return ui.sbPreviewLines->value(); }


[prev in list] [next in list] [prev in thread] [next in thread]