[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [publictransport] engine/timetablemate/src: Fix crash with invalid provider plugin XML files
From:       Friedrich_Karl_Tilman_Pülz <fpuelz () gmx ! de>
Date:       2012-11-30 20:36:57
Message-ID: 20121130203657.AF9E6A60DF () git ! kde ! org
[Download RAW message or body]

Git commit 860ee12b795d8a2f0078ed53c80d5136d5c95871 by Friedrich Karl Tilman Pülz.
Committed on 29/11/2012 at 02:30.
Pushed by fkpulz into branch 'master'.

Fix crash with invalid provider plugin XML files

It crashed as soon as the file was modified to an invalid state

M  +1    -0    engine/timetablemate/src/project.cpp

http://commits.kde.org/publictransport/860ee12b795d8a2f0078ed53c80d5136d5c95871

diff --git a/engine/timetablemate/src/project.cpp b/engine/timetablemate/src/project.cpp
index ada5f95..67dcfa7 100644
--- a/engine/timetablemate/src/project.cpp
+++ b/engine/timetablemate/src/project.cpp
@@ -860,6 +860,7 @@ public:
             }
         } else {
             kDebug() << "Service provider plugin is invalid" << reader.errorString() << fileName;
+            provider = ServiceProvider::createInvalidProvider( q );
             errorHappened( Project::ErrorWhileLoadingProject, reader.errorString() );
             insertProjectSourceTemplate();
             return false;

[prev in list] [next in list] [prev in thread] [next in thread]