[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [networkmanagement] libs/internals: Knm::Setting does not need to inherit from QObject. This may be
From:       Lamarque V. Souza <lamarque () kde ! org>
Date:       2012-10-31 22:56:08
Message-ID: 20121031225608.095F0A6078 () git ! kde ! org
[Download RAW message or body]

Git commit 5bc3699ee4fca04d1449c9b2bf101f87dc32c500 by Lamarque V. Souza.
Committed on 31/10/2012 at 23:50.
Pushed by lvsouza into branch 'master'.

Knm::Setting does not need to inherit from QObject. This may be the
cause of the crash when deleting Knm::WirelessSecuritySetting:

Core was generated by `kded4'.
Program terminated with signal 11, Segmentation fault.
0  0x0000003c84e0eebb in raise () from /lib64/libpthread.so.0
0  0x0000003c84e0eebb in raise () from /lib64/libpthread.so.0
1  0x00007f72d8f3c293 in KCrash::defaultCrashHandler (sig=11) at
/data/kde/trunk/KDE/kdelibs/kdeui/util/kcrash.cpp:346
2  <signal handler called>
3  0x00007f72d6d9ccf7 in QObject::~QObject (this=0xe24a90,
__in_chrg=<optimized out>) at kernel/qobject.cpp:858
4  0x00007f72c334c750 in Knm::Setting::~Setting (this=0xe24a90,
__in_chrg=<optimized out>) at
/data/kde/trunk/KDE/networkmanagement/libs/internals/setting.cpp:138
5  0x00007f72c334cfce in
Knm::WirelessSecuritySetting::~WirelessSecuritySetting (this=0xe24a90,
__in_chrg=<optimized out>) at
/data/kde/trunk/KDE/networkmanagement/libs/internals/settings/802-11-wireless-security.cpp:36
6  0x00007f72c334d000 in
Knm::WirelessSecuritySetting::~WirelessSecuritySetting (this=0xe24a90,
__in_chrg=<optimized out>) at
/data/kde/trunk/KDE/networkmanagement/libs/internals/settings/802-11-wireless-security.cpp:38
7  0x00007f72c3348d0c in Knm::Connection::clearSettings (this=0xb69df0)
at /data/kde/trunk/KDE/networkmanagement/libs/internals/connection.cpp:166

M  +1    -1    libs/internals/setting.h

http://commits.kde.org/networkmanagement/5bc3699ee4fca04d1449c9b2bf101f87dc32c500

diff --git a/libs/internals/setting.h b/libs/internals/setting.h
index b6eae9f..1376f19 100644
--- a/libs/internals/setting.h
+++ b/libs/internals/setting.h
@@ -28,7 +28,7 @@ License along with this library.  If not, see <http://www.gnu.org/licenses/>.
 namespace Knm
 {
 
-class KNMINTERNALS_EXPORT Setting: public QObject
+class KNMINTERNALS_EXPORT Setting
 {
 public:
     Q_FLAGS(secretsTypes)
[prev in list] [next in list] [prev in thread] [next in thread]