[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [Kamoso] 609915b: added some const and & in foreach's
From:       Alex Fiestas <alex () eyeos ! org>
Date:       2010-12-31 17:31:50
Message-ID: 20101231173150.B233DA60AE () git ! kde ! org
[Download RAW message or body]

commit 609915b27e120e3a0d058e18870dfc6abe3f088c
branch master
Author: Alex Fiestas <alex@eyeos.org>
Date:   Fri Dec 31 18:30:47 2010 +0100

    added some const and & in foreach's

diff --git a/src/devicemanager.cpp b/src/devicemanager.cpp
index 426059d..7aef407 100644
--- a/src/devicemanager.cpp
+++ b/src/devicemanager.cpp
@@ -31,8 +31,8 @@ DeviceManager *DeviceManager::s_instance = NULL;
 DeviceManager::DeviceManager()
 {
     //Checking current connected devices
-    foreach (Solid::Device device,
-            Solid::Device::listFromType(Solid::DeviceInterface::Video, QString())) {
+    QList <Solid::Device> deviceList = \
Solid::Device::listFromType(Solid::DeviceInterface::Video, QString()); +    foreach \
(const Solid::Device &device, deviceList) {  addDevice(device);
     }
 
@@ -134,9 +134,7 @@ void DeviceManager::deviceAdded(const QString &udi)
 
 void DeviceManager::webcamPlaying(const QString &udi)
 {
-    Device device;
-    foreach(device,m_deviceList) {
-        qDebug() << device.udi();
+    foreach(const Device &device, m_deviceList) {
         if(device.udi() == udi) {
             m_playingDevice = device;
             m_playingUdi = udi;


[prev in list] [next in list] [prev in thread] [next in thread]