[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdereview/rememberthemilk/applet
From:       Sebastian =?utf-8?q?K=C3=BCgler?= <sebas () kde ! org>
Date:       2009-04-30 23:53:13
Message-ID: 200905010153.14429.sebas () kde ! org
[Download RAW message or body]

On Thursday 30 April 2009 23:14:15 Andrew Stromme wrote:
> SVN commit 961884 by astromme:
>
> Tweak colors to be slightly more vibrant and match the rtm colors more

> -  painter->setOpacity(.25);
> +  painter->setOpacity(.5);

> -      gradient.setColorAt(0, Qt::red);
> +      gradient.setColorAt(0, QColor(255, 123, 0)); // reddish-orange

> -      gradient.setColorAt(0, Qt::blue);
> +      gradient.setColorAt(0, QColor(0, 132, 255)); // Darker blue

> -      gradient.setColorAt(0, Qt::cyan);
> +      gradient.setColorAt(0, QColor(53, 201, 255)); // Ligher Blue

hard-coded colours are nasty things, they can cause readability problems and 
clash with the theme the user is using. The best thing is usually to get rid 
of them and using variations of colours provided in the theme (for example 
changing their opacity). Change the theme between Oxygen and Air (which are 
both pretty much on the extreme ends of being dark and light) and you'll see 
if there are problems.

If you really, really want to keep those hardcoded colors, a way to minimize 
the risk making them (indeed) more translucent. It also makes it blend in 
nicer with the theme, which is usually a Big Plus from a aesthetical point of 
view.
-- 
sebas

 http://www.kde.org | http://vizZzion.org |  GPG Key ID: 9119 0EF9 

[prev in list] [next in list] [prev in thread] [next in thread]