[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE/kdenetwork/kopete/libkopete
From:       Charles Connell <charles () connells ! org>
Date:       2008-01-24 2:08:20
Message-ID: 200801232108.21072.charles () connells ! org
[Download RAW message or body]

On Wednesday 23 January 2008 08:55:21 pm you wrote:
> On Wednesday 23 January 2008 04:47:59 pm Charles Connell wrote:
> > SVN commit 765406 by cconnell:
> >
> > If group is named "Top Level", return actual top level group
> > BUG:150258
>
> This patch is wrong and needs to be reverted. The reason is that our so
> called "Top Level" group is not actually a group at all, but all those
> contacts that aren't in a normal group.
Yes, I know that. All this does is return a pointer to the top level group 
(which is implemented as a Kopete::Group) when the group name "Top Level" is 
requested. There was a condition where a user could have a group called "Top 
Level" in addition to the real top level group. To my knowledge, all that my 
patch does is prevent this from happening. I do not believe that it changes 
the behavior of the grouping system at all.

- Charles


[prev in list] [next in list] [prev in thread] [next in thread]