[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdelibs/khtml/ecma
From:       Dirk Mueller <mueller () kde ! org>
Date:       2003-09-30 23:17:39
[Download RAW message or body]

On Tuesday 30 September 2003 21:02, David Faure wrote:

> +
> +        // Update our document's rendering following the execution of the
> timeout callback. +        DOM::DocumentImpl *doc =
> static_cast<DOM::DocumentImpl*>(window->m_part->document().handle()); +    
>    doc->updateRendering();
>        }
>      }

This code misses null checks for window->m_part and document().handle() -> as 
this is called from a QTimer timeout this code is rather dangerous. 

BTW, it would be a lot cleaner to use Document::updateRendering() now that we 
have it. 


-- 
> Looking for a KDE-related EMail-Alias ? Get one at kdemail.net for FREE! <
[prev in list] [next in list] [prev in thread] [next in thread]