[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-bugs-dist
Subject:    Bug#28521: Acknowledgement (multible wallpapers do'nt stop by change to common dektop)
From:       Mueller Heinz <h_mueller_98 () yahoo ! com>
Date:       2001-07-31 15:10:33
[Download RAW message or body]

Sorry, It's too late for me, i must go to bed. to mistakes!!
(If the common desktop, number of desktop is on one not zero)

But here I've attach the working patch.

Sorry again, Heinz


On Tuesday 31 July 2001 15:38, you wrote:
> On Tuesday 31 July 2001 16:31, Mueller Heinz wrote:
> > Hello,
> >
> > Same problem with background programs.
> >
> > I've written a patch for this problem. Sorry but I'm not a c++ coder, but
> > the patch work for me.
> >
> > The problem was, the bgmanager looks for all desktops and if they have
> > multiple wallpapers or a background program, he execute this. But if i
> > use the common desktop, the bgmanager should only look at the desktop 0.
>
> Thanks for the patch.
> But I'm surprised.
> +    if (!m_bCommon)
> +       NumDesks = 0;
> Shouldn't that be
> +    if (m_bCommon)
> +       NumDesks = 0;
> ?
>
> As you say, IF you have a common desktop, THEN we should look only at desk
> 0. But you wrote the opposite (!m_bCommon). Or do I miss something ?


["bgmanager.cc.patch" (text/x-diff)]

--- bgmanager.cc	Wed Apr 25 00:23:40 2001
+++ bgmanager.commonpatch.cc	Tue Jul 31 16:56:43 2001
@@ -531,7 +531,11 @@
     QArray<int> running(m_Renderer.size());
     running.fill(0);
 
-    for (unsigned i=0; i<m_Renderer.size(); i++)
+    int NumDesks = m_Renderer.size();
+    if (m_bCommon) 
+       NumDesks = 1;
+
+    for (unsigned i=0; i<NumDesks; i++)
     {
         KBackgroundRenderer *r = m_Renderer[i];
         bool change = false;


[prev in list] [next in list] [prev in thread] [next in thread]