[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-bugs-dist
Subject:    [valgrind] [Bug 396290] [PATCH] Possible tool - allocfail
From:       Ivo Raisr <bugzilla_noreply () kde ! org>
Date:       2018-07-31 21:50:21
Message-ID: bug-396290-17878-0AqOI10f4j () http ! bugs ! kde ! org/
[Download RAW message or body]

https://bugs.kde.org/show_bug.cgi?id=396290

--- Comment #13 from Ivo Raisr <ivosh@ivosh.net> ---
(In reply to roger.light from comment #8)
> Created attachment 114229 [details]
> Updated patch with fixes and text callstacks.

Looks quite good. There are just few nits:
- Please remove trailing whitespace you introduced (a few occurrences).
For example 'git am' gives the list.
- Please have a space between 'while' and the condition.
- Please do better job with fixed size buffers (for example in
write_callstack_line).
  Some times ago, Florian underwent a painful exercise auditing all fixed size
buffers.
- You can use C99 constructs.
- Description for command line option --callstack-file deserves a better
wording.
- Description for command line option --show-fail-traces should be probably
renamed to --show-failed-traces (or simply --show-failed). The sentence should
start with capital letter anyway.
- Fix indentation of function af_instrument.

I will post my findings about using tool in a separate reply.

-- 
You are receiving this mail because:
You are watching all bug changes.=
[prev in list] [next in list] [prev in thread] [next in thread]