[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-bugs-dist
Subject:    [Spectacle] [Bug 389691] Ambiguous shortcut warning when pressing Ctrl+Q, Ctrl+S or Ctrl+Shift+S
From:       Henrik Fehlauer <bugzilla_noreply () kde ! org>
Date:       2018-02-14 22:39:59
Message-ID: bug-389691-17878-J4dyaWJopD () http ! bugs ! kde ! org/
[Download RAW message or body]

https://bugs.kde.org/show_bug.cgi?id=389691

Henrik Fehlauer <rkflx@lab12.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|                            |https://commits.kde.org/spe
                   |                            |ctacle/3f9e76afb161d00880f4
                   |                            |200d8059ec47375467ca
             Status|CONFIRMED                   |RESOLVED
         Resolution|---                         |FIXED

--- Comment #5 from Henrik Fehlauer <rkflx@lab12.net> ---
Git commit 3f9e76afb161d00880f4200d8059ec47375467ca by Henrik Fehlauer.
Committed on 14/02/2018 at 22:38.
Pushed by rkflx into branch 'master'.

Fix ambiguous shortcut warning when pressing save shortcuts

Summary:
When {nav Remember last used save mode} is enabled, pressing
{key Ctrl S} or {key Ctrl Shift S} repeatedly would result in a
ambiguous shortcut warning dialog.

This is because on every save the action was re-added to the dropdown
button, resulting in multiple shortcuts. It should be enough to set the
actions once, and then only swap the default action.

Depends on D10468
Ref T7841

Test Plan:
Press {key Ctrl S} twice, no warning dialog is shown anymore.
Both {nav Save} options still work as before and the last-used button is
set as the default.

Reviewers: #spectacle, ngraham

Reviewed By: #spectacle, ngraham

Subscribers: ngraham

Maniphest Tasks: T7841

Differential Revision: https://phabricator.kde.org/D10469

M  +14   -17   src/Gui/KSMainWindow.cpp
M  +3    -1    src/Gui/KSMainWindow.h

https://commits.kde.org/spectacle/3f9e76afb161d00880f4200d8059ec47375467ca

-- 
You are receiving this mail because:
You are watching all bug changes.=
[prev in list] [next in list] [prev in thread] [next in thread]