[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-bugs-dist
Subject:    [frameworks-kio] [Bug 384561] Dolphin copy operation is 4,5x slower than cp
From:       Jaime Torres <bugzilla_noreply () kde ! org>
Date:       2018-02-07 18:06:51
Message-ID: bug-384561-17878-yaLyNQ9L3k () http ! bugs ! kde ! org/
[Download RAW message or body]

https://bugs.kde.org/show_bug.cgi?id=384561

--- Comment #17 from Jaime Torres <jtamate@gmail.com> ---
Git commit 8d73867b3d4339ec026f92c4c2e89c265249aeb2 by Jaime Torres.
Committed on 07/02/2018 at 18:05.
Pushed by jtamate into branch 'master'.

Don't stat(/etc/localtime) between read() and write() copying files

Summary:

Unfortunately, QDateTime::currentDateTime() checks /etc/localtime
each time it is called.
Chaning to QElapsedTime, no check of /etc/localtime.
Reproducing bug 384561, the strace of file.so was something like:
read(), stat(/etc/localtime), stat(/etc/localtime),
stat(/etc/localtime), stat(/etc/localtime), stat(/etc/localtime),
write(), read() ......
Now it is: read(), write()
It also reduces the cpu in io/wait around 10% in a debug build.

Test Plan:
kio tests work as before
desktop: works in dolphin

Reviewers: #frameworks, fvogt, dfaure

Reviewed By: dfaure

Subscribers: fvogt, ngraham

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D9983

M  +14   -13   src/core/slavebase.cpp

https://commits.kde.org/kio/8d73867b3d4339ec026f92c4c2e89c265249aeb2

-- 
You are receiving this mail because:
You are watching all bug changes.=
[prev in list] [next in list] [prev in thread] [next in thread]