[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-bugs-dist
Subject:    [k3b] [Bug 384750] Progress bars don't work when I save a project to an ISO file
From:       Thomas Schmitt <bugzilla_noreply () kde ! org>
Date:       2017-12-07 10:38:29
Message-ID: bug-384750-17878-GoSa1Nmsqg () http ! bugs ! kde ! org/
[Download RAW message or body]

https://bugs.kde.org/show_bug.cgi?id=384750

--- Comment #17 from Thomas Schmitt <scdbackup@gmx.net> ---
Hi,

> I changed "Formats" to en-US in KDE regional settings

(I wonder how it looks if you choose Inuit or Samaritan Aramaic.)

> progress bars are working now.

So the cheapest, but possibly incomplete, fix would be to replace commas
by decimal points in
  int K3b::MkisofsHandler::parseMkisofsProgress( const QString& line )
of libk3b/projects/datacd/k3bmkisofshandler.cpp before interpreting the
number by
    double p = perStr.toDouble( &ok );

If one wants to prepare for xorrisofs, then one should submit to the
converter function .toDouble() the text beginning at its first digit or
decimal point.

A complete solution for mkisofs would be either to decode numbers with i18n 
in mind, or to prevent i18n of mkisofs. The latter seems to be the better 
solution in respect to preventing other i18n surprises and in order to keep 
the debugging output of mkisofs readable for international developers.

Have a nice day :)

Thomas

-- 
You are receiving this mail because:
You are watching all bug changes.=
[prev in list] [next in list] [prev in thread] [next in thread]