[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-bugs-dist
Subject:    [kwin] [Bug 376104] Quick tile window to any screen edge or corner de-maximizes the window without t
From:       Martin Flöser <bugzilla_noreply () kde ! org>
Date:       2017-12-04 17:31:27
Message-ID: bug-376104-17878-nRxlHWQ9pP () http ! bugs ! kde ! org/
[Download RAW message or body]

https://bugs.kde.org/show_bug.cgi?id=376104

Martin Flöser <mgraesslin@kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CONFIRMED                   |RESOLVED
         Resolution|---                         |FIXED
   Version Fixed In|                            |5.12.0
      Latest Commit|                            |https://commits.kde.org/kwi
                   |                            |n/8a2796d280dd7e891724cb6e6
                   |                            |d873a57e2ae8c52

--- Comment #29 from Martin Flöser <mgraesslin@kde.org> ---
Git commit 8a2796d280dd7e891724cb6e6d873a57e2ae8c52 by Martin Flöser.
Committed on 04/12/2017 at 16:25.
Pushed by graesslin into branch 'master'.

Fix regression from KWin 5.9 regarding quick tiling

Summary:
The regression got introduced with 9934f5b57537feae54afd0c4366c90253638ada2.
The order when setMaximize(false, false) was called changed in regard to
when the quick tiling mode was adjusted. But just changing the ordering
back was no solution as that would cause regressions in other areas
(unit tests fail).

This change builds up on the support for geometry update blocker on
Wayland to be able to better support this situation without causing
further regressions.

Also this change rethinks the code area. There is an idea behind
temporarily setting the quick tile mode to none and that is even
documented in a comment: it should not confuse maximize. So let's do
exactly that: call the maximize in the block where the quick tile
mode is temporarily wrong. As that is only one branch the else branch
performs the same steps.
FIXED-IN: 5.12.0

Test Plan: Confirmation in bug report that patch fixes issue

Reviewers: #kwin, #plasma

Subscribers: plasma-devel, kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D9178

M  +0    -16   autotests/integration/quick_tiling_test.cpp
M  +8    -5    geometry.cpp

https://commits.kde.org/kwin/8a2796d280dd7e891724cb6e6d873a57e2ae8c52

-- 
You are receiving this mail because:
You are watching all bug changes.=
[prev in list] [next in list] [prev in thread] [next in thread]