[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-bugs-dist
Subject:    [okular] [Bug 383915] Okular crashes with a segfault on reload for some synctex files
From:       Henrik Fehlauer <bugzilla_noreply () kde ! org>
Date:       2017-11-30 13:59:45
Message-ID: bug-383915-17878-0OJzCvZZEi () http ! bugs ! kde ! org/
[Download RAW message or body]

https://bugs.kde.org/show_bug.cgi?id=383915

Henrik Fehlauer <rkflx@lab12.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|https://commits.kde.org/oku |https://commits.kde.org/oku
                   |lar/bd20e48c3c8c82ed11ae73a |lar/dccd83783d145409e22d822
                   |ae0467c8ef49fca3b           |ec2b0a3645f549fa3
         Resolution|---                         |FIXED
             Status|REOPENED                    |RESOLVED

--- Comment #18 from Henrik Fehlauer <rkflx@lab12.net> ---
Git commit dccd83783d145409e22d822ec2b0a3645f549fa3 by Henrik Fehlauer.
Committed on 30/11/2017 at 13:57.
Pushed by rkflx into branch 'Applications/17.12'.

Prevent Okular from crashing when synctex logs an error

bd20e48c3c8c updated Okular's copy of the synctex code to 1.19.
Unfortunately since this version the upstream code logs errors like
`"! SyncTeX Error : Ignored record...` when accessing selected synctex
files created with older versions of synctex.

The upstream `_synctex_log` contains `va_list arg` as a parameter, but
fails to initialize and tear down this properly via `va_start` and
`va_end`. In general this seems to work for the single argument case.
However, once we apply our hardening patch to get rid of the
`gnu_printf format attribute` warning and thus introduce a variadic
argument, things go wrong.

To fix this, we add the missing code. The remaining changes are just
refreshing the patches.

Test Plan:
Opening `empty.pdf` with `empty.synctex.gz` from
https://bugs.kde.org/attachment.cgi?id=109116 located
in the same folder does not lead to Okular segfaulting anymore.

M  +11   -1    core/synctex/patches/04-gcc-specify-printf-format.diff
M  +1    -1    core/synctex/patches/06-mingw-_synctex_error.diff
M  +1    -1    core/synctex/patches/08-fix_cpp_comments.diff
M  +1    -1    core/synctex/patches/10-fix-typo.diff
M  +1    -1    core/synctex/patches/13-fix-Wundef-warnings.diff
M  +2    -0    core/synctex/synctex_parser_utils.c

https://commits.kde.org/okular/dccd83783d145409e22d822ec2b0a3645f549fa3

-- 
You are receiving this mail because:
You are watching all bug changes.=
[prev in list] [next in list] [prev in thread] [next in thread]