[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-bugs-dist
Subject:    [plasma-nm] [Bug 374990] New Network KCM Crash on Cancel
From:       David Edmundson <bugzilla_noreply () kde ! org>
Date:       2017-01-19 14:58:02
Message-ID: bug-374990-17878-HH77s99zSE () http ! bugs ! kde ! org/
[Download RAW message or body]

https://bugs.kde.org/show_bug.cgi?id=374990

David Edmundson <kde@davidedmundson.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
      Latest Commit|                            |https://commits.kde.org/kde
                   |                            |-cli-tools/8e7540a0e00beaa9
                   |                            |689593bd91898ce306730fd6
         Resolution|---                         |FIXED

--- Comment #2 from David Edmundson <kde@davidedmundson.co.uk> ---
Git commit 8e7540a0e00beaa9689593bd91898ce306730fd6 by David Edmundson.
Committed on 19/01/2017 at 14:57.
Pushed by davidedmundson into branch 'Plasma/5.9'.

Delete KCModule before deleting QApplication

Summary:
Currently the dialog just leaks. As a top level window it should get
cleaned up by the QApplication destructor.

This fixes a bug where a QMenu in QML (a top level window with no
parent) gets deleted by both QApplication and the KCM closing the
QQuickView which then deletes every QML Element including the menu.

Test Plan:
KCM's still load, everything looks the same
Jan confirmed it fixed the network KCM crash.

Reviewers: #plasma

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D4197

M  +1    -0    kcmshell/main.cpp

https://commits.kde.org/kde-cli-tools/8e7540a0e00beaa9689593bd91898ce306730fd6

-- 
You are receiving this mail because:
You are watching all bug changes.=
[prev in list] [next in list] [prev in thread] [next in thread]