[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-bugs-dist
Subject:    [krunner] [Bug 345750] The currency conversion doesn't show proper values
From:       Kai Uwe Broulik via KDE Bugzilla <bugzilla_noreply () kde ! org>
Date:       2016-05-12 8:57:21
Message-ID: bug-345750-17878-wBnuCQ2ERu () http ! bugs ! kde ! org/
[Download RAW message or body]

https://bugs.kde.org/show_bug.cgi?id=345750

Kai Uwe Broulik <kde@privat.broulik.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|                            |http://commits.kde.org/kuni
                   |                            |tconversion/db3a863c0592f87
                   |                            |37b67138043bb35839f27159d
             Status|CONFIRMED                   |RESOLVED
         Resolution|---                         |FIXED

--- Comment #11 from Kai Uwe Broulik <kde@privat.broulik.de> ---
Git commit db3a863c0592f8737b67138043bb35839f27159d by Kai Uwe Broulik.
Committed on 12/05/2016 at 08:57.
Pushed by broulik into branch 'master'.

Fix downloading currency exchange rates

QNetworkReply does not implement waitForReadyRead. Also, the code never
actually
created the cache dir it was trying to create a file in. Moreover, use
QSaveFile
to avoid saving a half-written file and improve the mutex usage as a nested
QEventLoop can easily lead to deadlocks.

REVIEW: 127251

M  +31   -23   src/currency.cpp

http://commits.kde.org/kunitconversion/db3a863c0592f8737b67138043bb35839f27159d

-- 
You are receiving this mail because:
You are watching all bug changes.
[prev in list] [next in list] [prev in thread] [next in thread]