[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-bugs-dist
Subject:    [digikam] [Bug 361047] Wishlist: make grouped images more prominently visible [patch]
From:       via KDE Bugzilla <bugzilla_noreply () kde ! org>
Date:       2016-05-02 13:48:25
Message-ID: bug-361047-17878-eMmtVLOpIj () http ! bugs ! kde ! org/
[Download RAW message or body]

https://bugs.kde.org/show_bug.cgi?id=361047

--- Comment #33 from caulier.gilles@gmail.com ---
In your stack proposal has the stack icon over the thumb. This one is already
outside the thumb because it's clickable to open/close the stack. If you move
it over the thumb, as the thumb is also clickable, this will not work. So the
icon must still outside the thumb.

The large border in gray delimit a the stack in a more visible way, and it's
more suitable. But a simple large gray border is not enough. We need rotated
border pixmap inside this gray area.

Note about your last patch V2 : 

1/
static const int IMAGE_BORDER_RADIUS = 3; 
==
const int radius = IMAGE_BORDER_RADIUS;

...is not necessary.

2/ use more CR in you cod. no need to attach all lines together.

3/ No need a cast here : 

const_cast<DItemDelegate*>(this)->d->thumbnailBorderCache.insert(cacheKey, new
QPixmap(pix));

d->thumbnailBorderCache.insert(cacheKey, new QPixmap(pix)); must be enough. Do
not try to make JAVA coding style please.

Gilles Caulier

-- 
You are receiving this mail because:
You are watching all bug changes.
[prev in list] [next in list] [prev in thread] [next in thread]