[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-bugs-dist
Subject:    [digikam] [Bug 355831] MySQL Schema Improvements
From:       Richard Mortimer via KDE Bugzilla <bugzilla_noreply () kde ! org>
Date:       2015-12-01 12:28:17
Message-ID: bug-355831-17878-mAKd267e3S () http ! bugs ! kde ! org/
[Download RAW message or body]

https://bugs.kde.org/show_bug.cgi?id=355831

--- Comment #39 from Richard Mortimer <richm+kde@oldelvet.org.uk> ---
Gilles,

1) I did not yet get chance to rebase the other two patches to separate those
from the face and thumbnail patches. I will do so within the next day.

2) I started to look at the Tags and Albums icon code. The entire code seems to
assume that an icon value of zero means no icon. This is not good for
referential integrity. Ideally all usages of qlonglong for icon value should be
replaced with something like QVariant that allows a null value too. I think
this is too big a change at the moment so my suggestion is that the database
storage code is modified to hardcode 0 as being equivalent to null in the
database. I did a quick test on both MySQL and SQLite and both work fine with
that assumption because when reading from the database a null icon is turned
into a zero when reading a longlong from QVariant that is null. Doing a full
QVariant conversion for icon fields might be something that could be included
in a GSoC project for PostgreSQL support.

-- 
You are receiving this mail because:
You are watching all bug changes.
[prev in list] [next in list] [prev in thread] [next in thread]