[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-bugs-dist
Subject:    [frameworks-frameworkintegration] [Bug 350758] Opening K/QFileDialog twice in a row freezes the pare
From:       Weng Xuetian <wengxt () gmail ! com>
Date:       2015-09-30 18:04:15
Message-ID: bug-350758-17878-9PWpEmUFli () http ! bugs ! kde ! org/
[Download RAW message or body]

https://bugs.kde.org/show_bug.cgi?id=350758

Weng Xuetian <wengxt@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CONFIRMED                   |RESOLVED
      Latest Commit|                            |http://commits.kde.org/fram
                   |                            |eworkintegration/6ae74671ca
                   |                            |68e9444db618207d662ad5d1c16
                   |                            |f31
         Resolution|---                         |FIXED

--- Comment #3 from Weng Xuetian <wengxt@gmail.com> ---
Git commit 6ae74671ca68e9444db618207d662ad5d1c16f31 by Weng Xuetian.
Committed on 30/09/2015 at 18:03.
Pushed by xuetianweng into branch 'master'.

Fix random file dialog not showing up problem.

When using QDialog to implement QPlatformDialog there will be a issue,
that QDialog will use a dummy invisible to make Qt aware that a modal
dialog exists. But for our usecase, this invisible dialog will show up
after our own qdialog and cause our dialog not accept any input.

The original workaround is to hide our dialog and show it again, but
this will hit QTBUG-48248 and our dialog will not show up at all
randomly. To avoid this, we delegate the call to show() on our
QDialog with a timer.
REVIEW: 125208

M  +10   -0    autotests/kfiledialog_unittest.cpp
M  +4    -0    autotests/kfiledialogqml_unittest.cpp
M  +15   -1    src/platformtheme/kdeplatformfiledialogbase.cpp
M  +5    -0    src/platformtheme/kdeplatformfiledialogbase_p.h
M  +23   -12   src/platformtheme/kdeplatformfiledialoghelper.cpp
M  +1    -0    src/platformtheme/kdeplatformfiledialoghelper.h

http://commits.kde.org/frameworkintegration/6ae74671ca68e9444db618207d662ad5d1c16f31

-- 
You are receiving this mail because:
You are watching all bug changes.
[prev in list] [next in list] [prev in thread] [next in thread]