[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-bugs-dist
Subject:    [krfb] [Bug 344571] krfb crashes on connect
From:       Albert Astals Cid <aacid () kde ! org>
Date:       2015-05-06 22:36:03
Message-ID: bug-344571-17878-3NvywQzy08 () http ! bugs ! kde ! org/
[Download RAW message or body]

https://bugs.kde.org/show_bug.cgi?id=344571

Albert Astals Cid <aacid@kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |UPSTREAM

--- Comment #23 from Albert Astals Cid <aacid@kde.org> ---
libvncserver in opensuse needs to be updated, ubuntu is using this patchset
that works

Description: Do not segfault on listenSock/listen6Sock
Author: mackyle

Index: libvncserver/libvncserver/sockets.c
===================================================================
--- libvncserver.orig/libvncserver/sockets.c    2014-05-01 10:11:04.295952467
+0200
+++ libvncserver/libvncserver/sockets.c 2014-05-01 10:16:22.953295982 +0200
@@ -402,9 +402,9 @@
       rfbLogPerror("rfbProcessNewConnection: error in select");
       return FALSE;
     }
-    if (FD_ISSET(rfbScreen->listenSock, &listen_fds)) 
+    if (rfbScreen->listenSock >= 0 && FD_ISSET(rfbScreen->listenSock,
&listen_fds)) 
       chosen_listen_sock = rfbScreen->listenSock;
-    if (FD_ISSET(rfbScreen->listen6Sock, &listen_fds)) 
+    if (rfbScreen->listen6Sock >= 0 && FD_ISSET(rfbScreen->listen6Sock,
&listen_fds)) 
       chosen_listen_sock = rfbScreen->listen6Sock;

     if ((sock = accept(chosen_listen_sock,

Or they can get an updated upstream version from libvncserver that also has
this fixed in a similar way, see
https://github.com/LibVNC/libvncserver/blob/master/libvncserver/sockets.c

-- 
You are receiving this mail because:
You are watching all bug changes.
[prev in list] [next in list] [prev in thread] [next in thread]