[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-bugs-dist
Subject:    [kdevplatform] [Bug 341875] Upload to ReviewBoard stopped working
From:       RJVB <rjvbertin () gmail ! com>
Date:       2014-12-14 15:41:33
Message-ID: bug-341875-17878-U9zSuCOlzT () http ! bugs ! kde ! org/
[Download RAW message or body]

https://bugs.kde.org/show_bug.cgi?id=341875

--- Comment #1 from RJVB <rjvbertin@gmail.com> ---
Modified reviewboardjobs.cpp HttpCall::finished to print the receivedData
before and after parsing:

    void HttpCall::finished()
    {
        QJson::Parser parser;
        QByteArray receivedData = m_reply->readAll();

        qDebug() << "parsing..." << receivedData;
        bool ok;
        m_result = parser.parse(receivedData, &ok);
        qDebug() << "parsing result=" << m_result;

and using kdevplatform git/1.7 on OS X, I get:

```
starting...  QUrl(
"https://rjvbb:*@git.reviewboard.kde.org/api/review-requests/" ) 
"repository=/repositories/kde-runtime.git/" 
content-type missing in HTTP POST, defaulting to
application/x-www-form-urlencoded. Use QNetworkRequest::setHeader() to fix this
problem.
parsing... "{"stat": "ok", "review_request": {"status": "pending",
"last_updated": "2014-12-14T15:31:42Z", "links": {"diffs": {"href":
"https://git.reviewboard.kde.org/api/review-requests/121512/diffs/", "method":
"GET"}, "repository": {"href":
"https://git.reviewboard.kde.org/api/repositories/147/", "method": "GET",
"title": "kde-runtime"}, "screenshots": {"href":
"https://git.reviewboard.kde.org/api/review-requests/121512/screenshots/",
"method": "GET"}, "self": {"href":
"https://git.reviewboard.kde.org/api/review-requests/121512/", "method":
"GET"}, "update": {"href":
"https://git.reviewboard.kde.org/api/review-requests/121512/", "method":
"PUT"}, "last_update": {"href":
"https://git.reviewboard.kde.org/api/review-requests/121512/last-update/",
"method": "GET"}, "reviews": {"href":
"https://git.reviewboard.kde.org/api/review-requests/121512/reviews/",
"method": "GET"}, "file_attachments": {"href":
"https://git.reviewboard.kde.org/api/review-requests/121512/file-attachments/",
"method": "GET"}, "draft": {"href":
"https://git.reviewboard.kde.org/api/review-requests/121512/draft/", "method":
"GET"}, "diff_context": {"href":
"https://git.reviewboard.kde.org/api/review-requests/121512/diff-context/",
"method": "GET"}, "submitter": {"href":
"https://git.reviewboard.kde.org/api/users/rjvbb/", "method": "GET", "title":
"rjvbb"}, "changes": {"href":
"https://git.reviewboard.kde.org/api/review-requests/121512/changes/",
"method": "GET"}, "delete": {"href":
"https://git.reviewboard.kde.org/api/review-requests/121512/", "method":
"DELETE"}}, "depends_on": [], "issue_resolved_count": 0, "ship_it_count": 0,
"id": 121512, "description": "", "target_people": [], "changenum": null,
"bugs_closed": [], "testing_done": "", "branch": "", "time_added":
"2014-12-14T15:31:42Z", "extra_data": {}, "public": false, "commit_id": null,
"blocks": [], "close_description": null, "text_type": "plain",
"issue_open_count": 0, "approved": false, "url": "/r/121512/", "absolute_url":
"https://git.reviewboard.kde.org/r/121512/", "target_groups": [], "summary":
"", "issue_dropped_count": 0, "approval_failure": "The review request has not
been marked \"Ship It!\""}}" 
parsing result= QVariant(QVariantMap, QMap(("review_request",
QVariant(QVariantMap, QMap(("absolute_url", QVariant(QString,
"https://git.reviewboard.kde.org/r/121512/") ) ( "approval_failure" , 
QVariant(QString, "The review request has not been marked "Ship It!"") ) (
"approved" ,  QVariant(bool, false) ) ( "blocks" ,  QVariant(QVariantList, () )
) ( "branch" ,  QVariant(QString, "") ) ( "bugs_closed" , 
QVariant(QVariantList, () ) ) ( "changenum" ,  QVariant(, ) ) (
"close_description" ,  QVariant(, ) ) ( "commit_id" ,  QVariant(, ) ) (
"depends_on" ,  QVariant(QVariantList, () ) ) ( "description" , 
QVariant(QString, "") ) ( "extra_data" ,  QVariant(QVariantMap, QMap() ) ) (
"id" ,  QVariant(qulonglong, 121512) ) ( "issue_dropped_count" , 
QVariant(qulonglong, 0) ) ( "issue_open_count" ,  QVariant(qulonglong, 0) ) (
"issue_resolved_count" ,  QVariant(qulonglong, 0) ) ( "last_updated" , 
QVariant(QString, "2014-12-14T15:31:42Z") ) ( "links" ,  QVariant(QVariantMap,
QMap(("changes", QVariant(QVariantMap, QMap(("href", QVariant(QString,
"https://git.reviewboard.kde.org/api/review-requests/121512/changes/") ) (
"method" ,  QVariant(QString, "GET") ) )  ) ) ( "delete" , 
QVariant(QVariantMap, QMap(("href", QVariant(QString,
"https://git.reviewboard.kde.org/api/review-requests/121512/") ) ( "method" , 
QVariant(QString, "DELETE") ) )  ) ) ( "diff_context" ,  QVariant(QVariantMap,
QMap(("href", QVariant(QString,
"https://git.reviewboard.kde.org/api/review-requests/121512/diff-context/") ) (
"method" ,  QVariant(QString, "GET") ) )  ) ) ( "diffs" , 
QVariant(QVariantMap, QMap(("href", QVariant(QString,
"https://git.reviewboard.kde.org/api/review-requests/121512/diffs/") ) (
"method" ,  QVariant(QString, "GET") ) )  ) ) ( "draft" , 
QVariant(QVariantMap, QMap(("href", QVariant(QString,
"https://git.reviewboard.kde.org/api/review-requests/121512/draft/") ) (
"method" ,  QVariant(QString, "GET") ) )  ) ) ( "file_attachments" , 
QVariant(QVariantMap, QMap(("href", QVariant(QString,
"https://git.reviewboard.kde.org/api/review-requests/121512/file-attachments/")
) ( "method" ,  QVariant(QString, "GET") ) )  ) ) ( "last_update" , 
QVariant(QVariantMap, QMap(("href", QVariant(QString,
"https://git.reviewboard.kde.org/api/review-requests/121512/last-update/") ) (
"method" ,  QVariant(QString, "GET") ) )  ) ) ( "repository" , 
QVariant(QVariantMap, QMap(("href", QVariant(QString,
"https://git.reviewboard.kde.org/api/repositories/147/") ) ( "method" , 
QVariant(QString, "GET") ) ( "title" ,  QVariant(QString, "kde-runtime") ) )  )
) ( "reviews" ,  QVariant(QVariantMap, QMap(("href", QVariant(QString,
"https://git.reviewboard.kde.org/api/review-requests/121512/reviews/") ) (
"method" ,  QVariant(QString, "GET") ) )  ) ) ( "screenshots" , 
QVariant(QVariantMap, QMap(("href", QVariant(QString,
"https://git.reviewboard.kde.org/api/review-requests/121512/screenshots/") ) (
"method" ,  QVariant(QString, "GET") ) )  ) ) ( "self" ,  QVariant(QVariantMap,
QMap(("href", QVariant(QString,
"https://git.reviewboard.kde.org/api/review-requests/121512/") ) ( "method" , 
QVariant(QString, "GET") ) )  ) ) ( "submitter" ,  QVariant(QVariantMap,
QMap(("href", QVariant(QString,
"https://git.reviewboard.kde.org/api/users/rjvbb/") ) ( "method" , 
QVariant(QString, "GET") ) ( "title" ,  QVariant(QString, "rjvbb") ) )  ) ) (
"update" ,  QVariant(QVariantMap, QMap(("href", QVariant(QString,
"https://git.reviewboard.kde.org/api/review-requests/121512/") ) ( "method" , 
QVariant(QString, "PUT") ) )  ) ) )  ) ) ( "public" ,  QVariant(bool, false) )
( "ship_it_count" ,  QVariant(qulonglong, 0) ) ( "status" ,  QVariant(QString,
"pending") ) ( "summary" ,  QVariant(QString, "") ) ( "target_groups" , 
QVariant(QVariantList, () ) ) ( "target_people" ,  QVariant(QVariantList, () )
) ( "testing_done" ,  QVariant(QString, "") ) ( "text_type" , 
QVariant(QString, "plain") ) ( "time_added" ,  QVariant(QString,
"2014-12-14T15:31:42Z") ) ( "url" ,  QVariant(QString, "/r/121512/") ) )  ) ) (
"stat" ,  QVariant(QString, "ok") ) )  ) 
starting...  QUrl(
"https://rjvbb:*@git.reviewboard.kde.org/api/review-requests/121512/diffs/" ) 
"------------N0clMOO5RMsJtavLKAno2gc1FvLfEGLxcL8k969DSnLC6KWt1nYwyFA
Content-Disposition: form-data; name="basedir"

/
------------N0clMOO5RMsJtavLKAno2gc1FvLfEGLxcL8k969DSnLC6KWt1nYwyFA
Content-Disposition: form-data; name="path"; filename="kdevelopV966442.patch"
Content-Type: text/x-patch

diff --git kioexec/main.cpp kioexec/main.cpp
index 06cd8f3..699e94f 100644
--- kioexec/main.cpp
+++ kioexec/main.cpp
@@ -21,6 +21,17 @@
 <SNIP>
------------N0clMOO5RMsJtavLKAno2gc1FvLfEGLxcL8k969DSnLC6KWt1nYwyFA--
" 
parsing... "{"fields": {"path": ["list index out of range"]}, "stat": "fail",
"err": {"msg": "One or more fields had errors", "code": 105}}" 
parsing result= QVariant(QVariantMap, QMap(("err", QVariant(QVariantMap,
QMap(("code", QVariant(qulonglong, 105) ) ( "msg" ,  QVariant(QString, "One or
more fields had errors") ) )  ) ) ( "fields" ,  QVariant(QVariantMap,
QMap(("path", QVariant(QVariantList, (QVariant(QString, "list index out of
range") )  ) ) )  ) ) ( "stat" ,  QVariant(QString, "fail") ) )  ) 
Could not upload the patch "Request Error: One or more fields had errors" 
```

-- 
You are receiving this mail because:
You are watching all bug changes.
[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic