[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-bugs-dist
Subject:    [umbrello] [Bug 340646] Fix issues reported by Coverity scan
From:       Oliver Kellogg <okellogg () users ! sourceforge ! net>
Date:       2014-11-30 19:07:14
Message-ID: bug-340646-17878-h9L7l1JgV1 () http ! bugs ! kde ! org/
[Download RAW message or body]

https://bugs.kde.org/show_bug.cgi?id=340646

--- Comment #1 from Oliver Kellogg <okellogg@users.sourceforge.net> ---
Git commit 9324cf30e4017d0f37a95d47da96882a8d713199 by Oliver Kellogg.
Committed on 30/11/2014 at 19:06.
Pushed by okellogg into branch 'master'.

Coverity check on master@375ea16 CIDs 83526, 83527, 83528, 83529, 83530 :
Logically dead code in file unittests/TEST_basictypes.cpp

- CID 83526: At function test_Corner_toString_fromString() for-loop,
  - use "<=" as comparison operator for staying in loop;
  - replace ++i by i *= 2 on iteration action. Reason: The values of
    the Corner enum are represented as 0x1, 0x2, 0x4, 0x8.

- CID 83527: At function test_RoleType_toString_fromString() for-loop,
  use "<=" as comparison operator for staying in loop.

- CID 83528: At function test_RoleType_toString_fromString() for-loop,
  use "<=" as comparison operator for staying in loop.

- CID 83529: At function test_Region_toString_fromString() for-loop,
  use "<=" as comparison operator for staying in loop.

- CID 83530: At function test_ProgrammingLanguage_toString_fromString()
  for-loop, use "<=" as comparison operator for staying in loop.

M  +5    -5    unittests/TEST_basictypes.cpp

http://commits.kde.org/umbrello/9324cf30e4017d0f37a95d47da96882a8d713199

-- 
You are receiving this mail because:
You are watching all bug changes.
[prev in list] [next in list] [prev in thread] [next in thread]