[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-bugs-dist
Subject:    [dolphin] [Bug 337946] Dolphin svn overlay icon
From:       Anthony <bvbfan () abv ! bg>
Date:       2014-10-31 12:40:15
Message-ID: bug-337946-17878-Hiez6CMqp3 () http ! bugs ! kde ! org/
[Download RAW message or body]

https://bugs.kde.org/show_bug.cgi?id=337946

--- Comment #4 from Anthony <bvbfan@abv.bg> ---
Do not think on post above, problem is not only there.
Let's search for directory that is not undercontrol beginRetrieval(const
QString& directory) directory = dir1/
fileviewsvnplugin.cpp:127
QMutableHashIterator<QString, ItemVersion> it(m_versionInfoHash);
    while (it.hasNext()) {
        it.next();
        if (it.key().startsWith(directory)) {
            it.remove();
        }
    }
now we remove it from hash and make new process "svn status --no-ignore dir1/"
dir1 is not in version control and result is "?       dir1" but in 169 we
search for '/' => filePath is empty, logic is not correct. Ugly patch can make
here, but function must be rewritten. fileviewsvnplugin.cpp:169 int pos =
filePath.indexOf('/'); after this must check for pos if(pos == -1 &&
filePath.contains(directory)) m_versionInfoHash.insert(directory, version);
must add current directory with version who is UnversionedVersion 99.9%.

-- 
You are receiving this mail because:
You are watching all bug changes.
[prev in list] [next in list] [prev in thread] [next in thread]