[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-bugs-dist
Subject:    [dolphin] [Bug 333078] When called externally tar archives open in ark instead of as a folder
From:       Frank Reininghaus <frank78ac () googlemail ! com>
Date:       2014-08-31 22:17:14
Message-ID: bug-333078-17878-yTZ99b4Irm () http ! bugs ! kde ! org/
[Download RAW message or body]

https://bugs.kde.org/show_bug.cgi?id=333078

Frank Reininghaus <frank78ac@googlemail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CONFIRMED                   |RESOLVED
   Version Fixed In|                            |4.14.1
         Resolution|---                         |FIXED
      Latest Commit|                            |http://commits.kde.org/kde-
                   |                            |baseapps/421e7ea410af32be2d
                   |                            |ff06207b459cefbdf43306

--- Comment #2 from Frank Reininghaus <frank78ac@googlemail.com> ---
Git commit 421e7ea410af32be2dff06207b459cefbdf43306 by Frank Reininghaus.
Committed on 31/08/2014 at 22:06.
Pushed by freininghaus into branch 'KDE/4.14'.

Make it possible to open archives via the command line

This used to work before afcf8961f6666a912e0e6e5072a000837f7cf6aa (only
if "Open archives as folder" was enabled in the settings though). The
reason why this commit broke it is that the mime type of a file is not
determined automatically any more before asking
KProtocolManager::protocolForArchiveMimetype for the correct protocol,
so the determination of the protocol may fail.

Keeping the isMimeTypeKnown() check in DolphinView::openItemAsFolderUrl
still makes sense, because it prevents GUI blocking if the user tries
to open many files at the same time.

Therefore, we now call determineMimeType() in
DolphinViewContainer::slotUrlIsFileError(const KUrl&) and then try to
determine the correct protocol and use it to open the archive in the
view, rather than hoping that slotItemActivated(item) will do the right
thing.
REVIEW: 119877
FIXED-IN: 4.14.1

M  +10   -1    dolphin/src/dolphinviewcontainer.cpp

http://commits.kde.org/kde-baseapps/421e7ea410af32be2dff06207b459cefbdf43306

-- 
You are receiving this mail because:
You are watching all bug changes.
[prev in list] [next in list] [prev in thread] [next in thread]