[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-bugs-dist
Subject:    [gwenview] [Bug 331504] Enter in crop mode exits it instead of applying changes
From:       Shlomi Fish <shlomif () shlomifish ! org>
Date:       2014-03-03 14:48:20
Message-ID: bug-331504-17878-WMWuLQTwZA () http ! bugs ! kde ! org/
[Download RAW message or body]

https://bugs.kde.org/show_bug.cgi?id=331504

--- Comment #4 from Shlomi Fish <shlomif@shlomifish.org> ---
Hi Vitaliy,

(In reply to comment #3)
> (In reply to comment #1)
> > "Enter" should simply do nothing (to avoid misapplying a crop by accident),
> 
> Hm... I think "Enter" key press is rarely an accident, I think "apply
> changes" is the normal meaning of Enter key in most applications :)

Enter can be pressed accidentally in many cases, and not all applications use
the "apply changes" meaning to it. In gwenview, it means switching between the
active image and the browse mode, and I believe this meaning should not be
conflated with applying the current changes. 

> 
> And the operation is non-destructive, so you can easily recover from an
> accident...

Also if you press enter twice (to get to browse mode)?

> 
> Maybe just apply changes on enter? It's more convenient than alt-c or
> something like that (for example I didn't know about that hotkey at all)

The "C" in the "Crop" button is underlined which indicates a keyboard shortcut,
and I think it would be preferable for such operations to not be done
accidentally.

Regards,

-- Shlomi Fish

-- 
You are receiving this mail because:
You are watching all bug changes.
[prev in list] [next in list] [prev in thread] [next in thread]