[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-bugs-dist
Subject:    [Bug 253822] stop after current track works only once but remains marked for stop
From:       Matěj Laitl <matej () laitl ! cz>
Date:       2012-11-26 19:45:32
Message-ID: bug-253822-17878-QdEclnyNpL () http ! bugs ! kde ! org/
[Download RAW message or body]

https://bugs.kde.org/show_bug.cgi?id=253822

Matěj Laitl <matej@laitl.cz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
   Version Fixed In|2.6                         |2.7
         Resolution|---                         |FIXED
      Latest Commit|                            |http://commits.kde.org/amar
                   |                            |ok/57e5bf466b364a0e086000b2
                   |                            |d24f00e1e336b22e

--- Comment #16 from Matěj Laitl <matej@laitl.cz> ---
Git commit 57e5bf466b364a0e086000b2d24f00e1e336b22e by Matěj Laitl.
Committed on 26/11/2012 at 20:36.
Pushed by laitl into branch 'master'.

PlaylistActions: fix sloppy "stop playing after" API and friends

...plus clean-up some EngineController <-> PlaylistActions interaction
and remove some hackiness like frequent calls to ::repaingPlaylist()

First, I wanted to merge the https://git.reviewboard.kde.org/r/107457/
- but the patch just opened my eyes to a greater flaw in the design of
"stop playing after"... So thanks, V. A. Amarnath - you triggered me
studying the code.
FIXED-IN: 2.7
REVIEW: 107457

M  +1    -0    ChangeLog
M  +15   -18   src/ActionClasses.cpp
M  +3    -3    src/EngineController.cpp
M  +1    -1    src/dbus/mpris1/PlayerHandler.cpp
M  +1    -1    src/dbus/mpris2/MediaPlayer2AmarokExtensions.cpp
M  +42   -35   src/playlist/PlaylistActions.cpp
M  +16   -23   src/playlist/PlaylistActions.h
M  +1    -1    src/playlist/view/PlaylistViewCommon.cpp
M  +2    -9    src/playlist/view/listview/PrettyListView.cpp
M  +5    -2    src/scriptengine/AmarokPlaylistScript.cpp

http://commits.kde.org/amarok/57e5bf466b364a0e086000b2d24f00e1e336b22e

-- 
You are receiving this mail because:
You are watching all bug changes.=
[prev in list] [next in list] [prev in thread] [next in thread]