[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-bugs-dist
Subject:    [Bug 309553] [Minimap] Problem with alternative colour scheme and widget misalignment
From:       Kåre Särs <kare.sars () iki ! fi>
Date:       2012-11-09 10:16:09
Message-ID: bug-309553-17878-1SbGRODWjT () http ! bugs ! kde ! org/
[Download RAW message or body]

https://bugs.kde.org/show_bug.cgi?id=309553

--- Comment #7 from Kåre Särs <kare.sars@iki.fi> ---
> --- Comment #6 from Emmanuel Lepage Vallée <elv1313@gmail.com> ---
> Hi,
> 
> >The bigest problem with the synced focus is that I would need to also
> >modify the text view and that is not something I'm too eager on doing
> >right now ;)
> -Last time I talk about that, but as I shown in the prototype attached to
> this bug, it does not require any modifications as focus tracking is a core
> QtGui feature. The only modification is hiding the right border, there is
> few way to do this without too much code. But there's still the bug in my
> prototype where the fadein animation is not disaplay. As long as that's not
> solved, it's a no go.

The thing I'm not too eager about is the hiding of the right part of the focus 
for the KateView.


> 
> -Alignment (katepart vs scrollbar) seem to be fixed. There is an extra pixel
> on the bottom, but it is mostly invisible.
> 
> -Y align for the 2 rect is still a little bit off (only visible when using
> KMag to track it) but only my 1 px. What about disabling the second rect
> when the whole view fit in a single page?
The ting is how do I detect this reliably...,  Hmm maybe if the slider is more 
than 2 pixels bigger.. I'll check it out.

> 
> -What about supporting color option for the background color and rect color
> (keep your as default)? If I was willing to implement it, could I just go
> ahead and commit it? I don't want to step on your feet while you are
> working on this.
I would like to avoid adding that option. Kate already contains quite a bunch 
of different colors to configure. The colors are now taken from the theme and 
light adjusted for the used foreground/background colors. If it seems broken 
for many we might re-think it.

> 
> -Thanks for merging the anti-aliasing part of the patch I posted, but what
> about the other change, is there a rational why it is bad or something?
> Oxygen have a 2px margin for scrollbar for the same rationals as I talked
> earlier.
I re-read your bug report after I had committed the anti-aliasing. I will 
apply the margin when I get to it :) I think 5 pixels rounding might be a bit 
too much... 

> 
> Still, thanks for working on this. Having these "modern" features in Kate is
> really, really cool! I complain a lot on details, I am aware of it, I just
> want this to be as awesome as it can get. Enough to be willing to put my
> code where my mouth is (and I don't do that very often).
I think it is great that so many want this feature and are willing to give 
feedback and even patches :)


/Kåre

-- 
You are receiving this mail because:
You are watching all bug changes.=
[prev in list] [next in list] [prev in thread] [next in thread]