[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-bugs-dist
Subject:    [Bug 282933] closing session crash
From:       Toralf Förster <toralf.foerster () gmx ! de>
Date:       2012-05-14 20:34:20
Message-ID: bug-282933-17878-QbYObd3XQo () http ! bugs ! kde ! org/
[Download RAW message or body]

https://bugs.kde.org/show_bug.cgi?id=282933

--- Comment #28 from Toralf Förster <toralf.foerster@gmx.de> ---
(In reply to comment #24)
> Git commit 53027ef8587845877ffa4e8492fdc10f2833db7c by Martin Gräßlin.
> Committed on 22/04/2012 at 09:27.
> Pushed by graesslin into branch 'master'.
> 
> Do not create Deleted on Workspace Shutdown
> 
> When the Workspace is shutting down the compositor is torn down
> before Clients and Unmanaged are released. This means that there
> is no need to create the Deleted windows.
> 
> Furthermore creating the Deleted manipulates the stacking_order
> M  +1    -1    kwin/workspace.cpp
I could apply the patch against 4.8.3 except the piece for this file, where I
created a separate diff :
tfoerste@n22 /etc/portage/patches/kde-base/kwin-4.8.3 $ cat workspace.patch 
--- a/kwin/workspace.cpp_orig   2012-05-13 19:13:03.931031792 +0200
+++ b/kwin/workspace.cpp        2012-05-13 19:13:15.706995478 +0200
@@ -530,7 +530,7 @@
         desktops.removeAll(*it);
     }
     for (UnmanagedList::iterator it = unmanaged.begin(), end =
unmanaged.end(); it != end; ++it)
-        (*it)->release();
+        (*it)->release(true);
 #ifdef KWIN_BUILD_DESKTOPCHANGEOSD
     delete desktop_change_osd;
 #endif

Now I'm wondering whether it ok to backport this to 4.8.x or not.

-- 
You are receiving this mail because:
You are watching all bug changes.=
[prev in list] [next in list] [prev in thread] [next in thread]