[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-bugs-dist
Subject:    [Bug 181847] Dolphin doesn't show crypt_LUKS partition (on built-in
From:       Dave Gilbert <gilbertd+kde () treblig ! org>
Date:       2010-12-31 23:54:16
Message-ID: 20101231235416.3E58F7924A () immanuel ! kde ! org
[Download RAW message or body]

https://bugs.kde.org/show_bug.cgi?id=181847





--- Comment #5 from Dave Gilbert <gilbertd+kde treblig org>  2011-01-01 00:54:14 ---
Well, here is a DANGEROUS half working patch:


--- kde4libs-4.5.90/solid/solid/backends/udisks/udisksdevice.cpp       
2010-12-01 22:23:26.000000000 +0000
+++ kde4libs-4.5.90-daveg/solid/solid/backends/udisks/udisksdevice.cpp 
2010-12-31 22:50:20.739968001 +0000
@@ -714,7 +714,7 @@

 bool UDisksDevice::isDeviceBlacklisted() const
 {
-    return property("DevicePresentationHide").toBool() ||
property("DevicePresentationNopolicy").toBool() ||
+    return property("DevicePresentationHide").toBool() || /*
property("DevicePresentationNopolicy").toBool() || DaveG */
             property("DeviceMountPaths").toStringList().contains("/boot") ||
             property("IdLabel").toString() == "System Reserved" ||
             property("IdUsage").toString().isEmpty();

So why is it dangerous? Well:
   1) I don't know what other type of device might show up that shouldn't - but
hey it's fine here on that count.

   2) OK, here's the real problem - when you unmount a crypted non-removable it
doesn't do a luksClose - so even though it asks you for the password again when
you double click, it doesn't really need to. (I checked, it's fine with
removables, so the removable path must do something else).

Still, I believe it is right to remove the check for DevicePresentationNopolicy
since the uDisks docs describes it as:
   'A hint if the device (or e.g. the multi-disk device that the device is part
of) shouldn't be automatically mounted / assembled.'

and we're not trying to do anything automatic.

Incidentally the other thing that this doesn't fix, is that the device notifier
doesn't show the crypted partition even when it's on 'All devices' - even
though Dolphin does (and I'd assumed they used the same list)

Dave

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
[prev in list] [next in list] [prev in thread] [next in thread]